Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Update2 #8532 Remove text truncator #10616

Merged
merged 2 commits into from
May 3, 2023
Merged

Fix Update2 #8532 Remove text truncator #10616

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4d6737
replace the textTruncator with TextTruncatorCss in ChannelCard.vue
Pursottam6003 May 2, 2023
f5a7726
update the ChannelCard.vue with textTruncatorCss
Pursottam6003 May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions kolibri/plugins/learn/assets/src/views/ChannelCard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
dir="auto"
:style="{ borderBottom: `1px solid ${$themeTokens.fineLine}` }"
>
<TextTruncator
<TextTruncatorCss
:text="title"
:maxHeight="titleHeight"
:maxLines="2"
:showTooltip="true"
/>
</h3>
Expand All @@ -43,9 +43,9 @@
span="3"
alignment="auto"
>
<TextTruncator
<TextTruncatorCss
:text="tagline"
:maxHeight="taglineHeight"
:maxLines="4"
:showTooltip="false"
/>
</KFixedGridItem>
Expand Down Expand Up @@ -84,15 +84,15 @@
import { validateLinkObject } from 'kolibri.utils.validators';
import responsiveWindowMixin from 'kolibri.coreVue.mixins.responsiveWindowMixin';
import CoachContentLabel from 'kolibri.coreVue.components.CoachContentLabel';
import TextTruncator from 'kolibri.coreVue.components.TextTruncator';
import TextTruncatorCss from 'kolibri.coreVue.components.TextTruncatorCss';
import ChannelThumbnail from './ChannelThumbnail';

export default {
name: 'ChannelCard',
components: {
ChannelThumbnail,
CoachContentLabel,
TextTruncator,
TextTruncatorCss,
},
mixins: [responsiveWindowMixin],
props: {
Expand Down Expand Up @@ -153,12 +153,6 @@
minHeight: `${this.overallHeight}px`,
};
},
titleHeight() {
return 60;
},
taglineHeight() {
return 155;
},
versionStyle() {
return {
color: this.$themeTokens.annotation,
Expand Down