Merge pull request #10616 from Pursottam6003/RemoveTextTruncator

Fix Update2 #8532 Remove text truncator
learningequality · May 3, 2023 · 4dad9b4 · 4dad9b4
2 parents 6402c35 + f5a7726
commit 4dad9b4
Showing 1 changed file with 6 additions and 12 deletions.
diff --git a/kolibri/plugins/learn/assets/src/views/ChannelCard.vue b/kolibri/plugins/learn/assets/src/views/ChannelCard.vue
@@ -21,9 +21,9 @@
         dir="auto"
         :style="{ borderBottom: `1px solid ${$themeTokens.fineLine}` }"
       >
-        <TextTruncator
+        <TextTruncatorCss
           :text="title"
-          :maxHeight="titleHeight"
+          :maxLines="2"
           :showTooltip="true"
         />
       </h3>
@@ -43,9 +43,9 @@
           span="3"
           alignment="auto"
         >
-          <TextTruncator
+          <TextTruncatorCss
             :text="tagline"
-            :maxHeight="taglineHeight"
+            :maxLines="4"
             :showTooltip="false"
           />
         </KFixedGridItem>
@@ -84,15 +84,15 @@
   import { validateLinkObject } from 'kolibri.utils.validators';
   import responsiveWindowMixin from 'kolibri.coreVue.mixins.responsiveWindowMixin';
   import CoachContentLabel from 'kolibri.coreVue.components.CoachContentLabel';
-  import TextTruncator from 'kolibri.coreVue.components.TextTruncator';
+  import TextTruncatorCss from 'kolibri.coreVue.components.TextTruncatorCss';
   import ChannelThumbnail from './ChannelThumbnail';
 
   export default {
     name: 'ChannelCard',
     components: {
       ChannelThumbnail,
       CoachContentLabel,
-      TextTruncator,
+      TextTruncatorCss,
     },
     mixins: [responsiveWindowMixin],
     props: {
@@ -153,12 +153,6 @@
           minHeight: `${this.overallHeight}px`,
         };
       },
-      titleHeight() {
-        return 60;
-      },
-      taglineHeight() {
-        return 155;
-      },
       versionStyle() {
         return {
           color: this.$themeTokens.annotation,