Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Learn, update useSearch() to extend baseUseSearch() #12517

Closed
1 task done
Tracked by #11888
marcellamaki opened this issue Aug 1, 2024 · 1 comment · Fixed by #12570 or #12566
Closed
1 task done
Tracked by #11888

In Learn, update useSearch() to extend baseUseSearch() #12517

marcellamaki opened this issue Aug 1, 2024 · 1 comment · Fixed by #12570 or #12566
Assignees

Comments

@marcellamaki
Copy link
Member

marcellamaki commented Aug 1, 2024

Prerequisite(s)

Preview Give feedback
  1. nucleogenesis

Begin by reviewing the epic #11888 and prerequiste #12516

Tasks

  1. Update useSearch composable in learn to just return useBaseSearch
  2. Update useBaseSearch to accept baseurl and fetchContentNodeProgress as function arguments, that default to undefined
  3. Invoke currentDeviceData in the learn useSearch to inject baseurl into useBaseSearch alongside fetchContentNodeProgress
  4. Update useBaseSearch to conditionally call fetchContentNodeProgress if it is defined

Acceptance Criteria

  1. Ensure that all references in Learn are properly updated - including updating all injection to useBaseSearch so it is simpler to move components in subsequent refactor
  2. Ensure that all search functionality still works as expected in learn
@marcellamaki marcellamaki changed the title In Learn, update useSearch() to extend baseUseSearch() and manage dependency injection for currentDeviceData and useLanguages In Learn, update useSearch() to extend baseUseSearch() Aug 13, 2024
nucleogenesis added a commit to nucleogenesis/kolibri that referenced this issue Aug 16, 2024
nucleogenesis added a commit to nucleogenesis/kolibri that referenced this issue Aug 16, 2024
This was referenced Aug 16, 2024
nucleogenesis added a commit to nucleogenesis/kolibri that referenced this issue Aug 21, 2024
@rtibbles
Copy link
Member

Mistakenly referenced from #12566 - reopening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment