Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor usesearch #12570

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Conversation

AlexVelezLl
Copy link
Member

@AlexVelezLl AlexVelezLl commented Aug 16, 2024

Summary

Finish refactor of useSearch in Learn to extend useBaseSearch.

References

Closes #12517.

Reviewer guidance

Run the server and see that search


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend labels Aug 16, 2024
@AlexVelezLl AlexVelezLl marked this pull request as ready for review August 23, 2024 14:17
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking - just a couple of questions, and we could perhaps make the diff more minimal in some places.

Not quite sure why tests are failing, but we definitely need to fix that before merge!

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimal diff, maximum impact! Manual testing checks out for both local and remote library searching, in the main Library page and in topics.

@rtibbles rtibbles merged commit 22063f9 into learningequality:develop Aug 23, 2024
34 checks passed
@AlexVelezLl AlexVelezLl deleted the refactor-usesearch branch August 23, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Learn, update useSearch() to extend baseUseSearch()
2 participants