-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor usesearch #12570
Refactor usesearch #12570
Conversation
Build Artifacts
|
998809a
to
fa1adfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing blocking - just a couple of questions, and we could perhaps make the diff more minimal in some places.
Not quite sure why tests are failing, but we definitely need to fix that before merge!
4953fe7
to
8123e6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minimal diff, maximum impact! Manual testing checks out for both local and remote library searching, in the main Library page and in topics.
Summary
Finish refactor of useSearch in Learn to extend useBaseSearch.
References
Closes #12517.
Reviewer guidance
Run the server and see that search
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)