Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy useSearch() into kolibri-common as baseUseSearch() #12516

Closed
Tracked by #12517 ...
marcellamaki opened this issue Aug 1, 2024 · 0 comments · Fixed by #12566
Closed
Tracked by #12517 ...

Copy useSearch() into kolibri-common as baseUseSearch() #12516

marcellamaki opened this issue Aug 1, 2024 · 0 comments · Fixed by #12566
Assignees

Comments

@marcellamaki
Copy link
Member

marcellamaki commented Aug 1, 2024

The useSearch() composable in Learn will be abstracted into kolibri-common so that it can be used across plugins. (At this point, Learn and Coach, but possibly also Device in the future!)

The core functionality should be moved into a composable called baseUseSearch that can be used across plugins.

In a future issue, additional requirements for particular uses (i.e. contentNodeProgress and currentDeviceData in Learn) will be handled within those plugins, via dependency injection.

Acceptance Criteria

  1. Moves useSearch into kolibri-common as useBaseSearch()
  2. Moves useLanguages into kolibri-common
  3. Ensure no console errors, and that build works correctly, even though this issue does not include refactoring in Learn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment