Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KResponsiveWindowMixin #719

Merged

Conversation

AlexVelezLl
Copy link
Member

@AlexVelezLl AlexVelezLl commented Aug 9, 2024

Description

Removes KResponsiveWindowMixin and all remaining references in docs.

Issue addressed

Addresses #679

Changelog

  • 719
    • Description: Removes KResponsiveWindowMixin.
    • Products impact: removed API.
    • Addresses: Remove KResponsiveWindowMixin #679.
    • Components: KResponsiveWindowMixin.
    • Breaking: yes.
    • Impacts a11y: no.
    • Guidance: Replace any use of KResponsiveWindowMixin with the new composable useKResponsiveWindow.

Steps to test

Is there still a reference to KResponsiveWindowMixin somewhere?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical and brittle code paths are covered by unit tests
  • The change is described in the changelog section above

Reviewer guidance

  • Is the code clean and well-commented?
  • Are there tests for this change?
  • Are all UI components LTR and RTL compliant (if applicable)?
  • Add other things to check for here

After review

  • The changelog item has been pasted to the CHANGELOG.md

Comments

@AlexVelezLl AlexVelezLl requested review from MisRob and AllanOXDi August 9, 2024 17:35
Copy link
Member

@AllanOXDi AllanOXDi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @AlexVelezLl

@AlexVelezLl
Copy link
Member Author

Thank you @AllanOXDi!!

@AlexVelezLl AlexVelezLl merged commit 9f78dd4 into learningequality:develop Aug 14, 2024
8 checks passed
@MisRob MisRob mentioned this pull request Aug 15, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants