Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KResponsiveWindowMixin #679

Closed
2 tasks
MisRob opened this issue Jul 12, 2024 · 1 comment
Closed
2 tasks

Remove KResponsiveWindowMixin #679

MisRob opened this issue Jul 12, 2024 · 1 comment
Assignees
Labels
Component: KResponsiveWindowMixin good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have

Comments

@MisRob
Copy link
Member

MisRob commented Jul 12, 2024

🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.

Summary

KResponsiveMixin has been superseded by the useKResponsiveWindow composable, which is the preferred way of accessing reactive window size information.

The goal of this issue is to remove KResponsiveMixin from the KDS codebase once and for all.

Guidance

  • Studio and Data Portal don't seem to use KResponsiveWindowMixin at all, and in Kolibri, we've migrated all its occurrences to useKResponsiveWindow already (Replace KResponsiveWindow mixin by useKResponsiveWindow composable kolibri#11321), so it shouldn't cause any issues. However, when installing the release with this update, it'd be best to double-check just in case there are some places I haven't noticed.

Acceptance Criteria

  • lib/KResponsiveWindowMixin.js no longer exists
  • All references to it are cleaned up from the code or from the documentation, if there are any
@MisRob MisRob added Component: KResponsiveWindowMixin good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have labels Jul 12, 2024
@AlexVelezLl AlexVelezLl self-assigned this Aug 9, 2024
@MisRob
Copy link
Member Author

MisRob commented Aug 15, 2024

Closed by #719

@MisRob MisRob closed this as completed Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: KResponsiveWindowMixin good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have
Projects
None yet
Development

No branches or pull requests

2 participants