Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KResponsiveWindowMixin #719

Merged
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,16 @@ Changelog is rather internal in nature. See release notes for the public overvie

## Upcoming version 5.x.x (`develop` branch)

- [719]
- **Description:** Removes KResponsiveWindowMixin.
- **Products impact:** removed API.
- **Addresses:** https://github.com/learningequality/kolibri-design-system/issues/679.
- **Components:** KResponsiveWindowMixin.
- **Breaking:** yes.
- **Impacts a11y:** no.
- **Guidance:** Replace any use of KResponsiveWindowMixin with the new composable useKResponsiveWindow.

[719]: https://github.com/learningequality/kolibri-design-system/pull/719
- [#687]
- **Description:** Adds logic that inserts ARIA live assertive and polite regions to an application's document body during KDS initialization and documents this on the new "Installation" page. Relatedly adds `useKLiveRegion` composable with public methods for updating the live regions with assertive and polite messages.
- **Products impact:** new API
Expand Down
2 changes: 1 addition & 1 deletion docs/pages/accessibility.vue
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
We should aim to allow zooming up to 200%, and down to 480x600 px in both profile and landscape. The app should always remain functional in all extreme screen sizes. Depending on the context, we may want to put additional effort into creating custom layouts optimized for particular screen sizes. For example, we should put additional effort into optimizing the mobile Learner experience, while for administrators this might not be as critical.
</p>
<p>
When designing and building layouts, we use the breakpoints defined by Material Design. These are exposed in our app by the <code>responsiveWindow</code> Vue component mixin. We should never use CSS media queries. See the <DocsInternalLink href="/layout" text="See the Layout page" /> for more information.
When designing and building layouts, we use the breakpoints defined by Material Design. These are exposed in our app by the <DocsLibraryLink component="useKResponsiveWindow" /> composable. We should never use CSS media queries. See the <DocsInternalLink href="/layout" text="See the Layout page" /> for more information.
</p>
</DocsPageSection>

Expand Down
2 changes: 1 addition & 1 deletion docs/pages/layout/index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
<li>Level 7: <code>&gt;= 1600px</code></li>
</ul>
<p>
Responsive layouts in the design system are built using reactive JavaScript state in Vue components rather than CSS media queries. This is done using <DocsLibraryLink component="KResponsiveWindow" /> when reactive window's size information is needed or <DocsLibraryLink component="KResponsiveElement" /> when reactive component's size information is needed.
Responsive layouts in the design system are built using reactive JavaScript state in Vue components rather than CSS media queries. This is done using <DocsLibraryLink component="useKResponsiveWindow" /> when reactive window's size information is needed or <DocsLibraryLink component="KResponsiveElement" /> when reactive component's size information is needed.
</p>
</DocsPageSection>

Expand Down
196 changes: 0 additions & 196 deletions lib/KResponsiveWindowMixin.js

This file was deleted.