DRAFT: Updates DD to dd and YYYY to yyyy to fix error from date-fns/format
#671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix error from date-fns
This was referenced Jun 24, 2024
|
The issue was resolved with a reverting of a PR (see learningequality/kolibri#12350) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error reported in learningequality/kolibri#12350 shows that
date-fnsis complaining about the use of all-caps date formatting throughout.Initially, I fixed this in the
DataPagecomponent in Kolibri, but then the complaint extended to KDS components.I am not sure if this is the proper fix, but I'm making the PR as I made the changes to be sure they'd fix the issue, and they do.
But, will wait for thoughts from @LianaHarris360