Fix generate logs; date formatting updates (KDS related) #12355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Facility
Build Artifacts
|
|
This change looks good and aligns with the |
nucleogenesis
force-pushed
the
fix--generate-session-summary-logs
branch
from
90f2308 to
1dca87d
Compare
nucleogenesis
requested review from
rtibbles
and removed request for
LianaHarris360
|
Hi @nucleogenesis - for some reason this is still not working and I am getting the same error in the console as before:
I can select my birth year in the Profile page though. |
|
I converted this into a draft as #12385 will fix the bug this intended to fix. Once we're able to get our dependencies & such aligned correctly across Kolibri & KDS, this can be revived as it includes necessary fixes when we update |
|
Let's close this, and we can file follow up issues for date-fns upgrades separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12350
Per @rtibbles suggestion, I've set the
date-fnspackage as a dependency in a new facility package.json to the same version used in KDS currently. Also added it to other relevant packages-dot-json.Reviewer guidance