Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #11980 from learningequality/dependabot/np… #12385

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Revert "Merge pull request #11980 from learningequality/dependabot/np… #12385

merged 1 commit into from
Jul 2, 2024

Conversation

nucleogenesis
Copy link
Member

Summary

Reverts #11980

Any reason not to do the revert commit this way? I tested it out and the date selection works as expected.

Fixes #12350

@nucleogenesis
Revert "Merge pull request learningequality#11980 from learningequali…
f0e6346 
…ty/dependabot/npm_and_yarn/date-fns-3.4.0"

This reverts commit 791170d, reversing
changes made to 85303c7.
@nucleogenesis nucleogenesis requested a review from rtibbles July 1, 2024 21:20
@nucleogenesis nucleogenesis mentioned this pull request Jul 1, 2024
Closed
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Build Artifacts

Asset type Download link
PEX file kolibri-.pex
Windows Installer (EXE) kolibri-0.17.0a0.dev0+git.178.gc90472ae-windows-setup-unsigned.exe
Debian Package kolibri_0.17.0a0.dev0+git.178.gc90472ae-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.17.0a0.dev0+git.178.gc90472ae-0.4.2.dmg
Android Package (APK) kolibri-0.17.0a0.dev0+git.178.gc90472ae-0.1.3-debug.apk
TAR file kolibri-0.17.0a0.dev0+git.178.gc90472ae.tar.gz
WHL file kolibri-0.17.0a0.dev0+git.178.gc90472ae-py2.py3-none-any.whl

rtibbles
rtibbles reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me - @pcenov if you can confirm that this fixes the issues with log exports, then we're good to go here.

@pcenov
Copy link
Member

pcenov commented Jul 2, 2024

Hi @nucleogenesis - LGTM, I confirm that the date selection and logs generation are working correctly now.

@nucleogenesis nucleogenesis requested a review from rtibbles July 2, 2024 17:10
@rtibbles rtibbles merged commit 2692958 into learningequality:develop Jul 2, 2024
30 checks passed
@rtibbles rtibbles mentioned this pull request Jul 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtibbles rtibbles rtibbles approved these changes

Assignees
No one assigned
Labels
DEV: frontend
Projects
None yet
Milestone
Kolibri 0.17: Enhanced Quiz Management
Development

Successfully merging this pull request may close these issues.

Kolibri 0.17 regression - Cannot generate session and summary logs
3 participants
@nucleogenesis @pcenov @rtibbles