Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kolibri-tools, fix lint errors #672

Conversation

nucleogenesis
Copy link
Member

Summary

In support of #671 and #578, which also then support fixing this critical bug in Kolibri: learningequality/kolibri#12350

  • Bumps to use the latest version published to NPM of the kolibri-tools package
  • Adds a lot of // eslint-disable-next-line no-console -- I think our console errors are generally purposeful and useful for development -- but I'm not sure if we should just disable that rule. Open to thoughts on this

Notable outstanding linting issue though

I kept getting this error for what seems to be every file:

TypeError: Class extends value undefined is not a constructor or null

Some light research suggests it's a circular import issue but I'm not super sure where to dig on that and don't want to spend time on it unless this, overall, is a correct step forward.

One thing I did was run the linter only on Vue files, which was successful. Then I did the same with only JS files, which was successful. But if I do both at the same time, TypeError: Class extends value undefined is not a constructor or null

@bjester
Copy link
Member

bjester commented Jun 25, 2024

kolibri-tools has already been updated here: #645

@nucleogenesis
Copy link
Member Author

I'm a dork, #645 is already doing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants