Bump kolibri-tools, fix lint errors #672
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In support of #671 and #578, which also then support fixing this critical bug in Kolibri: learningequality/kolibri#12350
// eslint-disable-next-line no-console
-- I think our console errors are generally purposeful and useful for development -- but I'm not sure if we should just disable that rule. Open to thoughts on thisNotable outstanding linting issue though
I kept getting this error for what seems to be every file:
TypeError: Class extends value undefined is not a constructor or null
Some light research suggests it's a circular import issue but I'm not super sure where to dig on that and don't want to spend time on it unless this, overall, is a correct step forward.
One thing I did was run the linter only on Vue files, which was successful. Then I did the same with only JS files, which was successful. But if I do both at the same time,
TypeError: Class extends value undefined is not a constructor or null