-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Makefile and distribute docs in sdist #4526
Conversation
lambda x: (os.path.join(kalite.ROOT_DATA_PATH, x[0]), x[1]), | ||
gen_data_files('docs/_build/html', optional=True) | ||
) | ||
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
I think the takeaway is that we can probably get this working with a little effort on Windows using MinGW. |
BTW, who is assigned to this? What part of #4348 does it address? Is this a release-blocker? I thought I was just supposed to give this a sanity check, but if you really wish to include it in 0.15.x, then I would also like to make sure the makefile is usable on Windows by testing it out. |
@rtibbles and I can sign off on this. |
Are one of you going to make sure it's usable on Windows? Or do you want me to do that? |
You'll be the best one for that @MCGallaspy. I can test this on the Mac as well. But getting parity across all platforms isn't important for me at the moment, since this will only be used by the deb installer for 0.15. So I wouldn't be too strict at this point. |
@aronasorman correct, the Makefile is not part of the release as pointed out in the description of the PR. However, the setup.py changes are... but theyre not very risky. |
I'm having issues with a constant Logging in with SSH, I can reissue @aronasorman any clues here? |
@benjaoming I've seen that error during 0.14, what I did was to install it first in my virtualenv. Maybe try adding that line in circle.yml? |
Re: my earlier comment, I'll sign off on this. |
@MCGallaspy that's cool, once it's merged we can go into more details about Win compat @aronasorman I'm not sure what line? The circle.yml is identical to the functional one in 0.15.x, and it has enabled the virtualenv at the point of issuing I'm gonna create a new PR in case Circle has a messed up cache. Then I can also clean up commit history. |
Change affecting 0.15 release
Docs are included in the sdist and built automatically by running
make sdist
.PR for #4348 (partly) and #4375
Change affecting build process
The PyPi and .deb for 0.15 will be released by using a new Makefile. Yay!
#4459
Makefile does this: