Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to sdist #4375

Closed
benjaoming opened this issue Sep 4, 2015 · 18 comments
Closed

Add documentation to sdist #4375

benjaoming opened this issue Sep 4, 2015 · 18 comments

Comments

@benjaoming
Copy link
Contributor

MANIFEST.in.dist should include the documentation.

The debian dist is built from an sdist, so that would immediately fix it. Windows already adds it in another way.

@cpauya does the OSX installer build from a PyPi sdist or do you create an sdist with setup.py sdist? Because in that case, fixing this issue will likely also add documentation to the OSX installer.

@aronasorman
Copy link
Collaborator

Not right now, although eventually it will, so it would be good to have it working through PyPi.

@benjaoming
Copy link
Contributor Author

@aronasorman okay but does it use the output of python setup.py sdist because that was my impression...

@aronasorman
Copy link
Collaborator

No, it does not use the sdist yet.

@benjaoming
Copy link
Contributor Author

Thanks, I got the link from Cyril to the setup.sh script :)

@rtibbles
Copy link
Member

rtibbles commented Feb 1, 2016

Status?

@benjaoming
Copy link
Contributor Author

Well, the docs (html output like the stuff on RTD) are bundled in, and part of the sdist. What's remaining now is that they are served in urls.py?

It's a waste to ship the docs without making the accessible to users. And it's not that hard to add, let this be a release blocker, I shall attend to it.

@MCGallaspy
Copy link
Contributor

It's already the case. However, the link only appears in the user menu when you're logged in.

@MCGallaspy
Copy link
Contributor

@MCGallaspy
Copy link
Contributor

Admittedly there's probably a much better way to present it.

@benjaoming
Copy link
Contributor Author

Maybe we can assign this to someone who will come up with a suggestion of how to refer the user to the bundled docs?

@MCGallaspy
Copy link
Contributor

I'll do it.

@MCGallaspy MCGallaspy assigned MCGallaspy and unassigned benjaoming Feb 9, 2016
@benjaoming
Copy link
Contributor Author

Just a quick note: Currently, we show documentation link to learners.. that doesn't make much sense?

screenshot from 2016-02-15 11 49 30

@MCGallaspy
Copy link
Contributor

that doesn't make much sense?

Who should be able to see it then?

@MCGallaspy
Copy link
Contributor

My first thought is to create another tab (a la "Learn" or the User tab) as a top-level nav item. This can be enabled or disabled by user type.

@radinamatic
Copy link
Member

Or maybe link the Learner User Manual page instead of the docs' index:
http://ka-lite.readthedocs.org/en/latest/usermanual/userman_learner.html

@benjaoming
Copy link
Contributor Author

@MCGallaspy docs contain contents for quite different audiences, it's important to provide the right deeplinks.

IMO our User Manual is suitable for Managers and Teachers, not Learners, it's way too technical. If we want documentation for learners, it's a symptom of our whole UI being to complicated.. defeats the purpose.

If you can add a Help tab and only show it to logged-in users who aren't learners, and as @radinamatic mentions deeplink to the User Manual, that'd be sufficient IMO?

@radinamatic
Copy link
Member

True up to the point @benjaoming.

Our docs as a whole are pretty technical, but the Learner User Manual page is down-to-the-ground enough (how to sign up, how to login). Granted maybe not for the kids learning how to count, but there is a lot of more advanced content in there (AP placement, college prep) that presume certain age and a minimum of tech-familiarity, if not "savvyness". Though I did add in my internal todo bucket, to think about the wording of the Accessing KA Lite topic and maybe re-locating the "Who is a “learner”?" phrase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants