Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final docs review #4501

Closed
MCGallaspy opened this issue Sep 25, 2015 · 13 comments
Closed

Final docs review #4501

MCGallaspy opened this issue Sep 25, 2015 · 13 comments
Assignees
Milestone

Comments

@MCGallaspy
Copy link
Contributor

Prior to release, take a careful look at the documentation. Create a documentation tarball for inclusion in installers.

@MCGallaspy MCGallaspy added this to the 0.15.0 milestone Sep 25, 2015
@MCGallaspy MCGallaspy self-assigned this Sep 25, 2015
@MCGallaspy
Copy link
Contributor Author

The red border applied for element highlighting in the screenshots appears to displace elements slightly -- should just lay on top, instead of moving them.

@rtibbles
Copy link
Member

@benjaoming
Copy link
Contributor

@MCGallaspy I'm working on embedding the docs in another issue, #4348 and #4375

@jinchuika
Copy link

Did you added the suggestion in #4049? I find it really useful

@rtibbles
Copy link
Member

I think @aronasorman is assigned to that, we will bug him about it today!

@MCGallaspy
Copy link
Contributor Author

@benjaoming

I'm working on embedding the docs in another issue, #4348 and #4375

Do those issues relate to this one? I wasn't very specific, but to be clear I'm only reviewing the documentation for accurate content, good layout, etc.

@benjaoming
Copy link
Contributor

@MCGallaspy

I was reacting on this part:

Create a documentation tarball for inclusion in installers.

...because what I'm working on is including them in the sdist.. but since this isn't part of the Windows installer, I guess we're talking about two different things here :)

@MCGallaspy
Copy link
Contributor Author

@benjaoming if you need some files to include now, my suggestion is to grab a tarball/zipfile from RTD. If you can wait a bit for me to upload fixed-up screenshots, then you can also build the html yourself. This is the relevant logic for including docs. You just need to drop the html output of sphinx-build into the source directory's docs/_build/html/ subdirectory. Lemme know if this needs some tweaking to build a .deb file.

Edit: see also


and
"docs_exist": getattr(settings, "DOCS_EXIST", False),

@MCGallaspy
Copy link
Contributor Author

I suppose we're done here.

@MCGallaspy
Copy link
Contributor Author

Oof, actually, I haven't created a tarball -- but now that updated screenshots have been committed, it's as simple as running make html in the docs directory. That will create all the appropriate files in the docs/_build/html directory. Will upload tarball upon request.

@benjaoming
Copy link
Contributor

@MCGallaspy
Copy link
Contributor Author

@benjaoming it's a single-page document.

@benjaoming
Copy link
Contributor

@MCGallaspy grr, okay, why can't RTD be perfect... but it's in the right layout with anchors and everything :)

the new sdist in pypi has docs/_build/html included

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants