-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final docs review #4501
Comments
The red border applied for element highlighting in the screenshots appears to displace elements slightly -- should just lay on top, instead of moving them. |
Mike - perhaps use the outline property instead? |
@MCGallaspy I'm working on embedding the docs in another issue, #4348 and #4375 |
Did you added the suggestion in #4049? I find it really useful |
I think @aronasorman is assigned to that, we will bug him about it today! |
I was reacting on this part:
...because what I'm working on is including them in the sdist.. but since this isn't part of the Windows installer, I guess we're talking about two different things here :) |
@benjaoming if you need some files to include now, my suggestion is to grab a tarball/zipfile from RTD. If you can wait a bit for me to upload fixed-up screenshots, then you can also build the html yourself. This is the relevant logic for including docs. You just need to drop the html output of sphinx-build into the source directory's Edit: see also
and ka-lite/kalite/facility/api_resources.py Line 187 in 9ab838e
|
I suppose we're done here. |
Oof, actually, I haven't created a tarball -- but now that updated screenshots have been committed, it's as simple as running |
@MCGallaspy actuall RTD has one: http://readthedocs.org/projects/ka-lite/downloads/htmlzip/latest/ (still 0.14) and http://readthedocs.org/projects/ka-lite/downloads/htmlzip/0.15.x/ |
@benjaoming it's a single-page document. |
@MCGallaspy grr, okay, why can't RTD be perfect... but it's in the right layout with anchors and everything :) the new sdist in pypi has docs/_build/html included |
Prior to release, take a careful look at the documentation. Create a documentation tarball for inclusion in installers.
The text was updated successfully, but these errors were encountered: