-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create top-level nav item for docs #4853
Create top-level nav item for docs #4853
Conversation
More immediate access to the content relevant for the user - I'd say it's a winner, @MCGallaspy! |
This failure must be unrelated to the changes: Scenario: Content is available # kalite/distributed/features/learn_content.feature:10
Given I open some available content # kalite/distributed/features/steps/learn_content.py:14
Given I open some available content # kalite/distributed/features/steps/learn_content.py:14 2.374s
Then I should see no alert # kalite/distributed/features/steps/learn_content.py:31
Then I should see no alert # kalite/distributed/features/steps/learn_content.py:31 6.401s
Traceback (most recent call last):
File "/home/ubuntu/virtualenvs/venv-2.7.9/lib/python2.7/site-packages/behave/model.py", line 1173, in run
match.run(runner.context)
File "/home/ubuntu/virtualenvs/venv-2.7.9/lib/python2.7/site-packages/behave/model.py", line 1589, in run
self.func(context, *args, **kwargs)
File "/home/ubuntu/ka-lite/kalite/distributed/features/steps/learn_content.py", line 35, in impl
assert_no_element_by_css_selector(context, ".alert")
File "/home/ubuntu/ka-lite/kalite/testing/behave_helpers.py", line 95, in assert_no_element_by_css_selector
_assert_no_element_by(context, By.CSS_SELECTOR, css_value, wait_time)
File "/home/ubuntu/ka-lite/kalite/testing/behave_helpers.py", line 85, in _assert_no_element_by
EC.presence_of_element_located((by, value))
File "/home/ubuntu/virtualenvs/venv-2.7.9/lib/python2.7/site-packages/selenium/webdriver/support/wait.py", line 91, in until_not
raise TimeoutException(message)
TimeoutException: Message:
Link to your job: https://saucelabs.com/jobs/f9090b82c09f489cb5e91413998dd57e |
From another thread (@benjaoming):
Good point, will address. |
However, I'm wondering if we should also show the link to non-logged-in users? |
I went ahead and made the suggested changes, @benjaoming. The link is not shown to non-logged-in users. |
Ah, test likely fails because documentation does not exist. |
@@ -19,6 +19,7 @@ dependencies: | |||
test: | |||
override: | |||
- make assets | |||
- make docs |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Yeah, this is super nice! Makes the docs extremely visible to the users that the docs work really well for in the current circumstances. As for non-logged in users... hm. Good question, but I would skip it because most users who aren't logged in a Learners in the bigger picture. But there could be a link in the first-run "create admin account" modal. |
698e6ca
to
0bd6835
Compare
At least one test in kalite.distributed.features.ui_regression depends on documentation being built.
0bd6835
to
61928c1
Compare
Looks great! Sorry if I was slow at merging it -- Github doesn't create direct notifications of subscribers when new commits arrive in a PR, so just post a whatever comment about the updates to makes sure subscribers are pinged. |
Create top-level nav item for docs
Fixes #4375 by adding a top-level item to the menu for docs if they are detected. Appears regardless of whether the user is logged in or not. Now also links directly to the user manual section, and I changed the display name accordingly. @radinamatic your opinion on this?
Screenshot: