0.15b3 #4550
Closed
0.15b3 #4550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd slipped in a longer debounce time. It's quite noticeable if you click on the star ratings quickly, and requires you to click a rating twice. Safe to lower it, since the debounced save will be called at most once.
Previously the element became stale *just* after being found and prior to being clicked -- evidently a race condition. If the `click` fails, this will retry -- repeated failure will raise a timeout error. As for *why* the reference could be stale -- it's possible if the view first calls renderSequence and then calls renderAll *before* the second rating element is clicked. Not sure how this could happen. May in fact be due to something else entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING! Merging this, merges and closes all PRs contained in this PR, and they may have a separate review process and amendments following. So don't merge this PR!! :)
Taking over #4532 (0.15b2)
New release, manually brewing the distributions:
Known issues
Included PRs
Installer links