Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Order/Max): add IsTop.isMax_iff and IsBot.isMin_iff #19305

Closed
wants to merge 2 commits into from

Conversation

pitmonticone
Copy link
Collaborator

Upstreamed from the Carleson project.

Co-authored-by: Floris van Doorn


Open in Gitpod

@pitmonticone pitmonticone added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI t-order Order theory labels Nov 20, 2024
Copy link

github-actions bot commented Nov 20, 2024

PR summary 432124ecf6

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsBot.isMin_iff
+ IsTop.isMax_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 20, 2024

✌️ pitmonticone can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@pitmonticone pitmonticone changed the title feat(Order/Max): add IsTop.isMax_iff feat(Order/Max): add IsTop.isMax_iff and IsBot.isMin_iff Nov 20, 2024
@pitmonticone
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Nov 20, 2024
Upstreamed from the [Carleson](https://github.com/fpvandoorn/carleson) project. 

Co-authored-by: Floris van Doorn
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 20, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Order/Max): add IsTop.isMax_iff and IsBot.isMin_iff [Merged by Bors] - feat(Order/Max): add IsTop.isMax_iff and IsBot.isMin_iff Nov 20, 2024
@mathlib-bors mathlib-bors bot closed this Nov 20, 2024
@mathlib-bors mathlib-bors bot deleted the Carleson/IsTop.isMax_iff branch November 20, 2024 22:27
TobiasLeichtfried pushed a commit that referenced this pull request Nov 21, 2024
Upstreamed from the [Carleson](https://github.com/fpvandoorn/carleson) project. 

Co-authored-by: Floris van Doorn
fpvandoorn pushed a commit to fpvandoorn/carleson that referenced this pull request Nov 21, 2024
- [x] Remove `_root_.ENNReal.inv_div` since upstreamed to Mathlib
leanprover-community/mathlib4#18704
- [x] Remove `Int.floor_le_iff` since upstreamed to Mathlib
leanprover-community/mathlib4#18552
- [x] Remove `dense_iff_iUnion_ball` since upstreamed to Mathlib
leanprover-community/mathlib4#19294
- [x] Remove `dist_eq_of_dist_zero` since upstreamed to Mathlib
leanprover-community/mathlib4#19294
- [x] Remove `IsTop.isMax_iff` since upstreamed to Mathlib
leanprover-community/mathlib4#19305
- [x] Remove `Int.Icc_of_eq_sub_one` since upstreamed to Mathlib
leanprover-community/mathlib4#19308

---------

Co-authored-by: grunweg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. t-order Order theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants