Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump (v4.14.0-rc2) #182

Merged
merged 12 commits into from
Nov 21, 2024
Merged

chore: bump (v4.14.0-rc2) #182

merged 12 commits into from
Nov 21, 2024

Conversation

@pitmonticone pitmonticone changed the title chore: bump (v4.14.0) chore: bump (v4.14.0-rc2) Nov 21, 2024
@pitmonticone
Copy link
Collaborator Author

This upstreaming+bumping PR is almost ready to merge.

I have upstreamed some theorems, bumped, upgraded stuff accordingly, but I needed to add one sorry here since gcongr didn't make progress after bumping Mathlib.

CC: @grunweg @fpvandoorn

@grunweg
Copy link
Collaborator

grunweg commented Nov 21, 2024

Taking a look at the last sorry now.

@grunweg
Copy link
Collaborator

grunweg commented Nov 21, 2024

Fixed the sorry and pushed some clean-ups. Opened at #185 - just pushing here somehow didn't work, and I don't feel like debugging why.

@pitmonticone
Copy link
Collaborator Author

pitmonticone commented Nov 21, 2024

Thank you, Michael!

Let me just merge master and then I think we can safely merge this one @fpvandoorn.

@pitmonticone pitmonticone marked this pull request as ready for review November 21, 2024 14:56
@grunweg
Copy link
Collaborator

grunweg commented Nov 21, 2024

👍 Feel free to cherry-pick #186 into this branch also: otherwise, I can rebase that PR when this one has landed.

@fpvandoorn
Copy link
Owner

Thanks!

@fpvandoorn fpvandoorn merged commit 0ba357e into master Nov 21, 2024
2 checks passed
@pitmonticone pitmonticone deleted the pitmonticone/bump-v4.14.0 branch November 22, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants