Tourniquets Text Over 20VW to Fix Table Length Issue #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes table length issue.
Using 400px still breaks if at minimum width. However, using Viewport Width (vw) makes it responsive, thus it works at all sizes without out the need for condition media queries.
QuirkyRobots
changed the title
Over VW Comment Change
QuirkyRobots
changed the title
|
Using Viewport Width (vw) makes it responsive, thus it works at all sizes without out the need for conditional media queries. |
QuirkyRobots
added a commit
to QuirkyRobots/lbry-app
that referenced
this pull request
Jun 26, 2018
Same CSS fix as lbryio#1692
|
This is great. |
|
Thanks @seanyesmunt I was looking for it to auto tourniquet based on the current I will spend more time on this at a later date and play around with things like converting the current table % values to VW to see if that is a better solution that will be globally acceptable for any sized area, which I think was @kauffj's concern. For now, these are a good fix with the current layout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes table length issue #1690
BEFORE
AFTER