Tourniquets Text to Fix Table Length Issue in Help #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same CSS fix as lbryio#1692
QuirkyRobots
changed the title
kauffj
reviewed
Jun 26, 2018
| @@ -13,6 +13,11 @@ table.table, | |||
| tr td:last-of-type, | |||
| tr th:last-of-type { | |||
| padding-right: $spacing-vertical * 2/3; | |||
| /*Tourniquets text over 20VW*/ | |||
There was a problem hiding this comment.
This probably can't become a property of all final table cells.
table.table--help {
td:nth-of-type(1) {
color: var(--text-color);
font-family: 'metropolis-semibold';
min-width: 130px;
}
td:nth-of-type(2) {
/*Tourniquets text over 20VW*/
max-width: 20vw;
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
}
}
|
Was better placed in the HELP section of the CSS. This way, it's only affecting the HELP table and not global assets. table.table--help {
td:nth-of-type(1) {
color: var(--text-color);
font-family: 'metropolis-semibold';
min-width: 130px;
}
td:nth-of-type(2) {
/*Tourniquets text over 20VW*/
max-width: 20vw;
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same CSS issue and fix as #1692 which fixes tables issues when the app is at minimum width.
These little details help keep the app looking professional, thus helping brand reputation/authority.
BEFORE
AFTER