Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Limit For Title and URL Length #1690

Closed
QuirkyRobots opened this issue Jun 26, 2018 · 6 comments
Closed

Reduce Limit For Title and URL Length #1690

QuirkyRobots opened this issue Jun 26, 2018 · 6 comments
Labels
area: creator type: discussion A conversation. No specific changes requested type: improvement Existing (or partially existing) functionality needs to be changed

Comments

@QuirkyRobots
Copy link
Contributor

QuirkyRobots commented Jun 26, 2018

Currently, there is a long limit for URL and title length, apparently 240 characters.

I imagine this could start being taxing on the blockchain in the future? I see no reason for titles and URLs over 60 characters and would help keep URLs and metadata looking clean. I guess it would also help prevent malicious code injections.

Also, long URLs break formatting in-app as shown in below image.

image

image

image

image

@QuirkyRobots
Copy link
Contributor Author

Formatting fix would look something like this, which tourniquets anything over the set length.

span.btn__content p {
    width: 300px;
    white-space: nowrap;
    overflow: hidden;
    text-overflow: ellipsis;
}

image

@tzarebczan
Copy link
Contributor

Notice the fee? :p Longer claim names require a larger fee. I'm not sure if the app is the right place to set the limits, we can leave that up for discussion.

@tzarebczan tzarebczan added type: improvement Existing (or partially existing) functionality needs to be changed type: discussion A conversation. No specific changes requested area: creator and removed needs: triage labels Jun 26, 2018
@QuirkyRobots
Copy link
Contributor Author

QuirkyRobots commented Jun 26, 2018

Yeah. Maybe a blockchain limitation would be better!

App formatting needs fixing though to cope with any titles longer than the width of the table.

@seanyesmunt

I'm currently experimenting with ways to do this. Text fields are displayed as <span> but need to be a text element for this to work. If changed to a <p> the fix is easy and you get the below fitted content.

CODE FIX

span.btn__content .long-text p {
    width: 300px;
    white-space: nowrap;
    overflow: hidden;
    text-overflow: ellipsis;
}

NOT FIXED

image

FIXED

image

@tzarebczan
Copy link
Contributor

Yea, that looks good to me. I think someone mentioned the same in a recent issue.

The blockchain hard-coded limitation is 240 :)

@alyssaoc
Copy link
Contributor

@tzarebczan Can we close this, based on the merged pr?

@neb-b
Copy link

neb-b commented Sep 27, 2018

Yep

@neb-b neb-b closed this as completed Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: creator type: discussion A conversation. No specific changes requested type: improvement Existing (or partially existing) functionality needs to be changed
Projects
None yet
Development

No branches or pull requests

5 participants