feat: bump solidity to 0.8.21

[holic]

closes #1448
closes #833

[changeset-bot]

🦋 Changeset detected

Latest commit: 5817aab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages

Name	Type
@latticexyz/cli	Major
@latticexyz/common	Major
@latticexyz/gas-report	Major
@latticexyz/noise	Major
@latticexyz/schema-type	Major
@latticexyz/store	Major
@latticexyz/world	Major
create-mud	Major
@latticexyz/block-logs-stream	Major
@latticexyz/config	Major
@latticexyz/dev-tools	Major
@latticexyz/protocol-parser	Major
@latticexyz/store-indexer	Major
@latticexyz/store-sync	Major
@latticexyz/recs	Major
@latticexyz/react	Major
@latticexyz/abi-ts	Major
@latticexyz/ecs-browser	Major
@latticexyz/faucet	Major
@latticexyz/network	Major
@latticexyz/phaserx	Major
@latticexyz/services	Major
@latticexyz/solecs	Major
solhint-config-mud	Major
solhint-plugin-mud	Major
@latticexyz/std-client	Major
@latticexyz/std-contracts	Major
@latticexyz/store-cache	Major
@latticexyz/utils	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[holic]

tried moving some events around as noted in #1448 but got weird natspec errors

Error: Internal exception in StandardCompiler::compile: /solidity/libsolidity/interface/Natspec.cpp(89): Throw in function static Json::Value solidity::frontend::Natspec::userDocumentation(const solidity::frontend::ContractDefinition &)
Dynamic exception type: boost::wrapexcept<solidity::langutil::InternalCompilerError>
std::exception::what: Solidity assertion failed
[solidity::util::tag_comment*] = Solidity assertion failed

Dynamic exception type: boost::wrapexcept<solidity::langutil::InternalCompilerError>
std::exception::what: Solidity assertion failed
[solidity::util::tag_comment*] = Solidity assertion failed

[alvrs]

looks good! let's add a changeset, i think this might be a breaking change as it requires consumers to update their solc version too

[holic]

looks good! let's add a changeset, i think this might be a breaking change as it requires consumers to update their solc version too

I am now kinda wondering if we want to leave the pragma alone to support a wider range of Solidity versions and just bump the foundry solc?

That said, we are already using features in e.g. 0.8.11 (abi.encodeCall) that isn't specified in the pragma version so we should bump that to something