Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use event reference instead of defining twice #1580

Closed
holic opened this issue Sep 22, 2023 · 4 comments
Closed

use event reference instead of defining twice #1580

holic opened this issue Sep 22, 2023 · 4 comments

Comments

@holic
Copy link
Member

holic commented Sep 22, 2023

IStore and StoreCore both define store events, but since #1473, we should be able to reference these from one place

However, we'll wanna ensure that these events still appear in the ABIs (they should)

Also should update tests to reference these instead of redefining
@holic holic mentioned this issue Sep 22, 2023
Closed
4 tasks
@alvrs
Copy link
Member

alvrs commented Sep 27, 2023

It would be nice to emit events from IStoreEvents from StoreCore, but there seems to be a known bug in solc for 0.8.21 that prevents it: ethereum/solidity#14430 - it's merged, but i don't think a version including the fix has been released yet

@alvrs alvrs closed this as completed Sep 27, 2023
@alvrs alvrs reopened this Sep 27, 2023
@alvrs
Copy link
Member

alvrs commented Sep 27, 2023

(didn't intend to close this)

@holic
Copy link
Member Author

holic commented Dec 12, 2023

sounds like foundry team suggests just skipping 0.8.21 and using 0.8.22: foundry-rs/foundry#6206 (comment)

@holic
Copy link
Member Author

holic commented Mar 21, 2024

we did this in #2356 and #2348

@holic holic closed this as completed Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@holic @alvrs