Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix all events and errors with library/contract name #1126

Closed
3 of 4 tasks
Tracked by #760
alvrs opened this issue Jul 10, 2023 · 3 comments · Fixed by #1568 or #1577
Closed
3 of 4 tasks
Tracked by #760

Prefix all events and errors with library/contract name #1126

alvrs opened this issue Jul 10, 2023 · 3 comments · Fixed by #1568 or #1577
Assignees

Comments

@alvrs
Copy link
Member

alvrs commented Jul 10, 2023

We currently prefix StoreCore events with StoreCore, but not World events/errors. We should align on one approach, and prefixing makes it easier to debug where an event came from.

TODO:

@alvrs alvrs converted this from a draft issue Jul 10, 2023
@alvrs alvrs added this to the Contracts stable milestone Jul 10, 2023
@alvrs alvrs changed the title Prefix all events with library/contract name Prefix all events and errors with library/contract name Jul 10, 2023
@dk1a
Copy link
Contributor

dk1a commented Jul 10, 2023

We should align on one approach, and prefixing makes it easier to debug where an event came from

agree with prefixing

@alvrs alvrs mentioned this issue Jul 3, 2023
17 tasks
@holic
Copy link
Member

holic commented Jul 10, 2023

Also forge flattens ABI directory structures, which means there's higher chance of collision if we had something named Context but also pull in a lib that has Context contract already. Feels a little silly to name based on what's probably a forge bug, but could help for visibility anyway.

@holic
Copy link
Member

holic commented Sep 22, 2023

when we do events, we should see if we can consolidate into one place (e.g. interface or library) and reference them directly

I believe the latest solc version should enable this but I encountered errors when I tried (but didn't dig too deep): #1473 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
3 participants