-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefix all events and errors with library/contract name #1126
Comments
agree with prefixing |
Also forge flattens ABI directory structures, which means there's higher chance of collision if we had something named |
when we do events, we should see if we can consolidate into one place (e.g. interface or library) and reference them directly I believe the latest solc version should enable this but I encountered errors when I tried (but didn't dig too deep): #1473 (comment) |
We currently prefix
StoreCore
events withStoreCore
, but notWorld
events/errors. We should align on one approach, and prefixing makes it easier to debug where an event came from.TODO:
mud/packages/world/src/interfaces/IModule.sol
Lines 14 to 15 in b18d491
The text was updated successfully, but these errors were encountered: