Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): rename events for readability and consistency with errors #1577

Merged
merged 6 commits into from
Sep 22, 2023

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Sep 22, 2023

Fixes #1126

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2023

🦋 Changeset detected

Latest commit: 44adc20

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@latticexyz/block-logs-stream Major
@latticexyz/dev-tools Major
@latticexyz/store-sync Major
@latticexyz/store Major
@latticexyz/store-indexer Major
@latticexyz/cli Major
@latticexyz/react Major
@latticexyz/world Major
@latticexyz/abi-ts Major
@latticexyz/common Major
@latticexyz/config Major
create-mud Major
@latticexyz/ecs-browser Major
@latticexyz/faucet Major
@latticexyz/gas-report Major
@latticexyz/network Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/protocol-parser Major
@latticexyz/recs Major
@latticexyz/schema-type Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-client Major
@latticexyz/std-contracts Major
@latticexyz/store-cache Major
@latticexyz/utils Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -26,9 +26,9 @@ latestBlockNumber$
publicClient,
address,
events: parseAbi([
"event StoreDeleteRecord(bytes32 tableId, bytes32[] keyTuple)",
"event Store_DeleteRecord(bytes32 tableId, bytes32[] keyTuple)",
"event StoreSetField(bytes32 tableId, bytes32[] keyTuple, uint8 schemaIndex, bytes data)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops this is old

@alvrs alvrs marked this pull request as ready for review September 22, 2023 20:18
@alvrs alvrs requested a review from dk1a as a code owner September 22, 2023 20:18
@alvrs alvrs changed the title feat(store): rename events for consistency with errors feat(store): rename events for readability and consistency with errors Sep 22, 2023
@alvrs alvrs merged commit af639a2 into main Sep 22, 2023
10 checks passed
@alvrs alvrs deleted the alvrs/store-event-names branch September 22, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefix all events and errors with library/contract name
2 participants