Added PHP 8.0 support #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added PHP 8.0 constraint to composer.json - Removed PHP less 7.3 support from composer.json - Modified composer.json to implement phpunit 9.3 - Fixed phpunit tests and config to be compatible with the phpunit 9.3 - Added PHP 8.0 to .travis.yml - Removed PHP less 7.3 support from .travis.yml Added PHP 8.0 support - Added PHP 8.0 constraint to composer.json - Removed PHP less 7.3 support from composer.json - Modified composer.json to implement phpunit 9.3 - Fixed phpunit tests and config to be compatible with the phpunit 9.3 - Added PHP 8.0 to .travis.yml - Removed PHP less 7.3 support from .travis.yml Signed-off-by: Gennadiy Litvinyuk <[email protected]>
|
Implementation of #12 |
Closed
6 tasks
|
Travis CI is gone and the new workflow for continuous integration must be added that the tests can be run. (See also on other components for help, e.g. laminas-feed.) |
CI Configuration: from Travis to Github Actions Reverted phpunit schema Bumped up laminas-coding-standard CS Fixes Signed-off-by: Gennadiy Litvinyuk <[email protected]>
Signed-off-by: Gennadiy Litvinyuk <[email protected]>
weierophinney
requested changes
Apr 8, 2021
src/ComposerJsonRetrievalTrait.php
Outdated
| @@ -11,11 +11,11 @@ | |||
| use Composer\Factory; | |||
| use Composer\Json\JsonFile; | |||
|
|
|||
| use function call_user_func; | |||
There was a problem hiding this comment.
Since this patch updates the skeleton to set the minimum PHP version to 7.3, we can stop using call_user_func(), and instead just call the callable directly (as 7.2 forwards allows any callable to be directly invoked). Please remove this import, and then update the getComposerJson() call such that:
$composerFile = call_user_fun($this->composerFileFactory);becomes:
$composerFile = ($this->composerFileFactory)();
src/OptionalPackagesInstaller.php
Outdated
| @@ -15,6 +15,11 @@ | |||
| use Composer\Package\RootPackageInterface; | |||
| use Composer\Package\Version\VersionParser; | |||
| use Composer\Plugin\PluginInterface; | |||
|
|
|||
| use function call_user_func; | |||
There was a problem hiding this comment.
Same comment as for the ComposerJsonRetrievalTrait, only this time, the function to update will be runInstaller().
Signed-off-by: Gennadiy Litvinyuk <[email protected]>
samsonasik
approved these changes
Apr 15, 2021
|
Thank you @gennadiylitvinyuk |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added PHP 8.0 support
Signed-off-by: Gennadiy Litvinyuk [email protected]