-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide support for PHP 8.0 #31
Conversation
Signed-off-by: Dick Ittmann <[email protected]>
|
this may need laminas-skeleton-installer to support php 8 first, ref laminas/laminas-skeleton-installer#19 |
@ittmann please update |
"laminas/laminas-component-installer": "^2.4" "laminas/laminas-skeleton-installer": "^0.3" Signed-off-by: Dick Ittmann <[email protected]>
Tested again (in docker with php:8.0-apache) after the version changes suggested by samsonasik dc82d2c Choosing MVC testing support or installing laminas-test after initial project creation fails (PHP 8.0 support hasn't been added to laminas-test yet) Everything works as expected with php:7.3-apache / the current project Dockerfile and docker-compose.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are extra components that need to be check against php 8, but for basic installation, I think it is ready 👍
I am merging it now, I will verify the latest components inside "extra" config. |
Thank you @ittmann |
Adds support for PHP 8.0 as requested in #27
(it is installed during initial project creation when MVC testing support is installed as described in README.md)
Tested in docker with php:8.0-rc-apache
The skeleton app is compatible/runs without any issues.
phpunit reports an error on the use of the deprecated function libxml_disable_entity_loader in laminas-test, which should be fixed when PHP 8.0 support is added to laminas-test