Switch from Travis-CI to GitHub Actions #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adopts workflow prototyped in laminas/laminas-eventmanager#15 - mainly to check that Psalm integration works as expected. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
|
Is psalm ignoring baseline in the GHA? |
Part of it, but not all of it; my guess is a difference in Psalm versions between last run and this one — which is why @Ocramius is suggesting we always commit a lockfile, to ensure tooling runs on consistent versions. |
Psalm flagged new errors because a new version was installed. Most of these we need to continue ignoring, as the type casting keeps the tests happy. Also adds composer.lock to the repo, so that we will install the locked version of Psalm for future runs. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
weierophinney
force-pushed
the
feature/gha-workflow
branch
from
cb73216 to
fed04a6
Compare
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopts workflow prototyped in laminas/laminas-eventmanager#15 - mainly to check that Psalm integration works as expected.