Adopt Laminas CI Workflow

[Slamdunk]

Blocks #25

[froschdesign]

@Slamdunk
The composer.lock file must be added.

[Slamdunk]

I have never understood how and why: I would generate it under my local PC settings, which is arbitrary and way different from CI.

Is this ok? If so, how is it useful in the first place?

[froschdesign]

Is this ok? If so, how is it useful in the first place?

See the checks running on this pull request, the CI workflow is still missing.

See also:

• https://github.com/laminas/laminas-ci-matrix-action#create-a-ci-matrix-for-use-in-a-github-action
• Switch from Travis-CI to GitHub Actions laminas-feed#35

[Slamdunk]

I've committed and pushed it. Still, I feel you didn't answer my question:

1. https://github.com/laminas/laminas-ci-matrix-action#create-a-ci-matrix-for-use-in-a-github-action doesn't require a composer.lock committed:

   Whether to run against a "locked" set of dependencies based on the presence of a composer.lock file.

2. Switch from Travis-CI to GitHub Actions laminas-feed#35 doesn't say how someone should generate it

[Slamdunk]

Now build passes, PSalm fails due to laminas/laminas-continuous-integration-action#9

[froschdesign]

Still, I feel you didn't answered my question…

You are absolutely right, but I am not the expert on this topic and so I can not much help here, unfortunately only with some hints.

[Slamdunk]

Do you think we can close 2.10.0 milestone today?

[Slamdunk]

I see you put this into 2.10.0 milestone, but there's no 2.10.x branch

[froschdesign]

I see you put this into 2.10.0 milestone, but there's no 2.10.x branch

Right, I just saw that too.
I'm on the road and need to check what I can do via the GitHub app.

[Slamdunk]

I'm on the road and need to check what I can do via the GitHub app.

Oh, never mind, please wait for the proper time and location to work on this 😉

[weierophinney]

've committed and pushed it. Still, I feel you didn't answer my question:

1. https://github.com/laminas/laminas-ci-matrix-action#create-a-ci-matrix-for-use-in-a-github-action doesn't require a composer.lock committed:

   Whether to run against a "locked" set of dependencies based on the presence of a composer.lock file.

It's needed for non-unit test checks. The reason is because updates to QA tooling can quickly lead to different results on different runs of the same command. As examples:

• Things not previously flagged as CS issues now are.
• Things not previously caught by static analysis now are, even though no relevant code changes were made.

As such, we want to commit a lockfile so that these remain idempotent between invocations on the same set of code.

2. laminas/laminas-feed#35 doesn't say how someone should generate it

You're right, so I wrote up the process here: https://gist.github.com/weierophinney/b003e50c3c2667d08076caf31ebd36a4 (and just added the bit about Psalm cache directory issues as well).

[weierophinney]

@Slamdunk Okay, the laminas-continuous-integration-action is updated to resolve the Psalm caching issue. Now the check is failing due to actual errors!

Ping me when resolved, and I'll get this merged and released.

[Slamdunk]

These redundant casts cannot be purged as they would result in a BC break, see:

laminas-server/test/Method/ParameterTest.php

Lines 70 to 78 in 6488e14

	public function testSettingDescriptionShouldCastToString(): void
	{
	$message = 123456;
	/** @psalm-suppress InvalidScalarArgument */
	$this->parameter->setDescription($message);
	$test = $this->parameter->getDescription();
	$this->assertNotSame($message, $test);
	$this->assertEquals($message, $test);
	}

[weierophinney]

You can suppress them individually, or add them to the baseline, then.

[Slamdunk]

Ping @weierophinney