Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Use custom workload for Istio metrics test #654

Merged
merged 2 commits into from
Dec 20, 2023
Merged

test: Use custom workload for Istio metrics test #654

merged 2 commits into from
Dec 20, 2023

Conversation

chrkl
Copy link
Contributor

@chrkl chrkl commented Dec 20, 2023 •
edited
Loading

Description

Changes proposed in this pull request (what was done and why):

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • New features have a milestone set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub issue has a respective area and kind label.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • Adjusted the documentation if the change is user-facing.
  • The feature is unit-tested
  • The feature is e2e-tested

@chrkl chrkl added area/tests Writing/adding/Refactoring tests or checks kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Dec 20, 2023
@chrkl chrkl added this to the 1.7.0 milestone Dec 20, 2023
@chrkl chrkl requested a review from a team as a code owner December 20, 2023 09:21
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 20, 2023
rakesh-garimella
rakesh-garimella reviewed Dec 20, 2023
View reviewed changes
test/integration/istio/metrics_istio_input_test.go Outdated
app1 := kitk8s.NewPod("app-1", app1Ns).WithPodSpec(telemetrygen.PodSpec(telemetrygen.SignalTypeMetrics))
app2 := kitk8s.NewPod("app-2", app2Ns).WithPodSpec(telemetrygen.PodSpec(telemetrygen.SignalTypeMetrics))
objs = append(objs, app1.K8sObject(), app2.K8sObject())
sourceSpec := corev1.PodSpec{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this to internal package ? It would be easy to follow the test

@chrkl chrkl force-pushed the istio-metrics-test branch from 604c166 to 69228a3 Compare December 20, 2023 12:21
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 20, 2023
@kyma-bot kyma-bot merged commit 90a76e7 into kyma-project:main Dec 20, 2023
17 checks passed
@chrkl chrkl deleted the istio-metrics-test branch December 20, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakesh-garimella rakesh-garimella rakesh-garimella approved these changes

Assignees

@rakesh-garimella rakesh-garimella

Labels
area/tests Writing/adding/Refactoring tests or checks cla: yes Indicates the PR's author has signed the CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chrkl @rakesh-garimella @kyma-bot