Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Use custom workload for Istio metrics test #654

Merged
merged 2 commits into from
Dec 20, 2023
Merged

test: Use custom workload for Istio metrics test #654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
486c845
test: Use custom workload for Istio metrics test
chrkl Dec 20, 2023
69228a3
Small refactorings
chrkl Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ fmt: ## Run go fmt against code.

.PHONY: vet
vet: ## Run go vet against code.
go vet ./...
go vet --tags e2e,istio ./...

.PHONY: tidy
tidy: ## Check if there any dirty change for go mod tidy.
Expand Down
53 changes: 47 additions & 6 deletions test/integration/istio/metrics_istio_input_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (

. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/types"
"sigs.k8s.io/controller-runtime/pkg/client"

Expand All @@ -15,7 +16,6 @@ import (
kitmetricpipeline "github.com/kyma-project/telemetry-manager/test/testkit/kyma/telemetry/metric"
. "github.com/kyma-project/telemetry-manager/test/testkit/matchers/metric"
"github.com/kyma-project/telemetry-manager/test/testkit/mocks/backend"
"github.com/kyma-project/telemetry-manager/test/testkit/mocks/telemetrygen"
"github.com/kyma-project/telemetry-manager/test/testkit/periodic"
"github.com/kyma-project/telemetry-manager/test/testkit/verifiers"
)
Expand All @@ -26,6 +26,8 @@ var _ = Describe("Metrics Istio Input", Label("metrics"), func() {
backendName = "backend"
app1Ns = "app-1"
app2Ns = "app-2"
nginxImage = "europe-docker.pkg.dev/kyma-project/prod/external/nginx:1.23.3"
curlImage = "europe-docker.pkg.dev/kyma-project/prod/external/curlimages/curl:7.78.0"
)

// https://istio.io/latest/docs/reference/config/metrics/
Expand Down Expand Up @@ -71,6 +73,39 @@ var _ = Describe("Metrics Istio Input", Label("metrics"), func() {
telemetryExportURL string
)

sourcePodSpec := func() corev1.PodSpec {
return corev1.PodSpec{
Containers: []corev1.Container{
{
Name: "source",
Image: curlImage,
Command: []string{
"/bin/sh",
"-c",
"while true; do curl http://destination:80; sleep 1; done",
},
},
},
}
}

destinationPodSpec := func() corev1.PodSpec {
return corev1.PodSpec{
Containers: []corev1.Container{
{
Name: "destination",
Image: nginxImage,
Ports: []corev1.ContainerPort{
{
ContainerPort: 80,
Protocol: corev1.ProtocolTCP,
},
},
},
},
}
}

makeResources := func() []client.Object {
var objs []client.Object
objs = append(objs, kitk8s.NewNamespace(backendNs).K8sObject(),
Expand All @@ -87,9 +122,15 @@ var _ = Describe("Metrics Istio Input", Label("metrics"), func() {
IstioInput(true, kitmetricpipeline.IncludeNamespaces(app1Ns))
objs = append(objs, metricPipeline.K8sObject())

app1 := kitk8s.NewPod("app-1", app1Ns).WithPodSpec(telemetrygen.PodSpec(telemetrygen.SignalTypeMetrics))
app2 := kitk8s.NewPod("app-2", app2Ns).WithPodSpec(telemetrygen.PodSpec(telemetrygen.SignalTypeMetrics))
objs = append(objs, app1.K8sObject(), app2.K8sObject())
source1 := kitk8s.NewPod("source", app1Ns).WithPodSpec(sourcePodSpec())
destination1 := kitk8s.NewPod("destination", app1Ns).WithPodSpec(destinationPodSpec()).WithLabel("app", "destination")
service1 := kitk8s.NewService("destination", app1Ns).WithPort("http", 80)

source2 := kitk8s.NewPod("source", app2Ns).WithPodSpec(sourcePodSpec())
destination2 := kitk8s.NewPod("destination", app2Ns).WithPodSpec(destinationPodSpec()).WithLabel("app", "destination")
service2 := kitk8s.NewService("destination", app2Ns).WithPort("http", 80)

objs = append(objs, source1.K8sObject(), destination1.K8sObject(), service1.K8sObject(kitk8s.WithLabel("app", "destination")), source2.K8sObject(), destination2.K8sObject(), service2.K8sObject(kitk8s.WithLabel("app", "destination")))

return objs
}
Expand Down Expand Up @@ -142,11 +183,11 @@ var _ = Describe("Metrics Istio Input", Label("metrics"), func() {
}, periodic.TelemetryEventuallyTimeout, periodic.TelemetryInterval).Should(Succeed())
})

It("Should deliver metrics from app1Ns", func() {
It("Should deliver metrics from app-1 namespace", func() {
verifiers.MetricsFromNamespaceShouldBeDelivered(proxyClient, telemetryExportURL, app1Ns, istioProxyMetricNames)
})

It("Should not deliver metrics from app2Ns", func() {
It("Should not deliver metrics from app-2 namespace", func() {
verifiers.MetricsFromNamespaceShouldNotBeDelivered(proxyClient, telemetryExportURL, app2Ns)
})
})
Expand Down
Loading