Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter istio metrics related to telemetry component communication #621

Closed
a-thaler opened this issue Dec 11, 2023 · 1 comment
Closed

Filter istio metrics related to telemetry component communication #621

a-thaler opened this issue Dec 11, 2023 · 1 comment
Assignees
Labels
area/metrics MetricPipeline kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@a-thaler
Copy link
Collaborator

a-thaler commented Dec 11, 2023

Description

Users are interested in the Istio metrics of the business related communication and will accept the cost for storing them. The communication to the telemetry module is not really crucial for the users and will cause a higher volume of data, think of the telemetry-metric-agent scraping a bigger amount of pods.

To be consistent with the trace gateway implementation, all metrics related to telemetry system related communication should be filtered out by default.

Criteria

  • As a user I will not see any Istio metrics related to communication from/to telemetry components
  • As a telemetry module maintainer, I want to avoid unneeded code, so orphaned rules should be removed

Reasons

Attachments

Release Notes

When using the Istio input of a MetricPipeline, communication with the telemetry gateways gets excluded by default
@rakesh-garimella
Copy link
Contributor

Filters have been implemented in metric agent. Currently following is dropped:

  • Metric with source telemetry-metric-agent
  • Metric with destination telemetry-metric-gateway
  • Metric with destination telemetry-trace-collector
    Obsolete filter ruless have been dropped in trace collector

@a-thaler a-thaler added this to the 1.7.0 milestone Dec 21, 2023
@a-thaler a-thaler added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics MetricPipeline kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants