Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make insecure flag in tls config optional #360

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

chrkl
Copy link
Contributor

@chrkl chrkl commented Aug 24, 2023

Description

#347 added mTLS support for TracePipelines. The added TLS sub-resource of the CRD make the insecure flag mandatory. This PR makes the flag optional and defaults to false.

Changes proposed in this pull request:

  • Make insecure flag in OTLP TLS settings optional

Related Issues and Documents

Closes:

Related issues: kyma-project/kyma#17995

Traceability

  • The PR is linked to a GitHub Issue.
  • New features have a milestone label set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub Issue has a respective area label.
  • The follow-up issues (if any) are linked in the Related Issues section.

Testability

The feature is unit-tested:

  • Yes.
  • No, because unit tests are not needed.
  • No, because only the CRD is changed, not visible in Go code

The feature is e2e-tested:

  • Yes.
  • No, because e2e-tests are not needed.
  • No, because only the CRD is changed, not visible in Go code

Tests conducted for the PR:

Codebase

  • My code follows the Effective Go style guidelines.
  • The code was planned and designed following the defined architecture and the separation of concerns.
  • The code has sufficient comments, particularly for all hard-to-understand areas.
  • This PR adds value and shows no feature creep.
  • I have augmented the test suite that proves my fix is effective or that my feature works.
  • Adjusted the documentation if the change is user-facing.

@chrkl chrkl requested review from a team as code owners August 24, 2023 13:26
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 24, 2023
@chrkl chrkl added area/tracing and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 24, 2023
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 24, 2023
NHingerl
NHingerl previously approved these changes Aug 24, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 24, 2023
@chrkl chrkl force-pushed the insecure-optional branch from b730fd7 to 3549b8e Compare August 24, 2023 15:20
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Aug 24, 2023
@kyma-bot
Copy link
Contributor

@chrkl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-telemetry-manager-governance 3549b8e link false /test pull-telemetry-manager-governance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 24, 2023
@kyma-bot kyma-bot merged commit 869b757 into kyma-project:main Aug 24, 2023
@chrkl chrkl deleted the insecure-optional branch August 24, 2023 17:22
@a-thaler a-thaler added this to the 0.10.0 milestone Aug 25, 2023
@a-thaler a-thaler added the kind/bug Categorizes issue or PR as related to a bug. label Aug 25, 2023
@a-thaler a-thaler added area/traces TracePipeline and removed area/tracing labels Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/traces TracePipeline kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants