-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add mTLS support for TracePipeline OTLP output #347
Conversation
Skipping CI for Draft Pull Request. |
/test all |
/test all |
return cfg | ||
} | ||
|
||
if !cfg.Insecure { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I restored the isInsecureOutput function that checks if the endpoint scheme is http. It is necessary that this is set before line 82 (output.TLS == nil
) to have the same functionality as before.
This line checks if the output is not insecure, i.e., line 80 (cfg.Insecure = isInsecureOutput(otlpEndpointValue)
) returned false. If this is the case, we allow to overwrite the TLS setting.
It is not a nice solution but it should be the same as the behavior before
return fmt.Sprintf("HEADER_%s_%s", envvar.MakeEnvVarCompliant(pipelineName), envvar.MakeEnvVarCompliant(header.Name)) | ||
} | ||
|
||
func makeTLSVariable(prefix, pipelineName string) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is more generic than it's name. Let's either make 3 specific function for each purpose or use a more generic name.
/retest-required |
config/development/telemetry.kyma-project.io_metricpipelines.yaml
Outdated
Show resolved
Hide resolved
/retest |
@dennis-ge: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description
Changes proposed in this pull request:
Related Issues and Documents
Closes:
Related issues: kyma-project/kyma#17995
Traceability
area
label.Related Issues
section.Testability
The feature is unit-tested:
The feature is e2e-tested:
Tests conducted for the PR:
Codebase