Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Documentation for Traces mTLS support #361

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

a-thaler
Copy link
Collaborator

Description

Changes proposed in this pull request:

  • renamed diagrams to logs/traces-* to be able to add metrics-* diagrams
  • added docu for mTLS
  • extended description of new attributes

Related Issues and Documents

Closes:

Related issues: #347

Traceability

  • The PR is linked to a GitHub Issue.
  • New features have a milestone label set.
  • New features have defined acceptance criteria in a corresponding GitHub Issue, and all criteria are satisfied with this PR.
  • The corresponding GitHub Issue has a respective area label.
  • The follow-up issues (if any) are linked in the Related Issues section.

Testability

The feature is unit-tested:

  • Yes.
  • No, because unit tests are not needed.
  • No, because of ...

The feature is e2e-tested:

  • Yes.
  • No, because e2e-tests are not needed.
  • No, because of ...

Tests conducted for the PR:

Codebase

  • My code follows the Effective Go style guidelines.
  • The code was planned and designed following the defined architecture and the separation of concerns.
  • The code has sufficient comments, particularly for all hard-to-understand areas.
  • This PR adds value and shows no feature creep.
  • I have augmented the test suite that proves my fix is effective or that my feature works.
  • Adjusted the documentation if the change is user-facing.

@a-thaler a-thaler requested review from a team as code owners August 24, 2023 14:31
@kyma-bot kyma-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 24, 2023
@a-thaler a-thaler changed the title docs: added documentation for Traces mTLS support docs: Documentation for Traces mTLS support Aug 24, 2023
@a-thaler a-thaler added area/documentation Documentation changes kind/feature Categorizes issue or PR as related to a new feature. labels Aug 24, 2023
@a-thaler a-thaler added this to the 0.10.0 milestone Aug 24, 2023
chrkl
chrkl previously approved these changes Aug 24, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 24, 2023
Copy link
Contributor

@NHingerl NHingerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick'n'dirty

docs/user/03-traces.md Outdated Show resolved Hide resolved
docs/user/03-traces.md Outdated Show resolved Hide resolved
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Aug 24, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 24, 2023
@chrkl
Copy link
Contributor

chrkl commented Aug 24, 2023

/retest

2 similar comments
@a-thaler
Copy link
Collaborator Author

/retest

@a-thaler
Copy link
Collaborator Author

/retest

@kyma-bot
Copy link
Contributor

kyma-bot commented Aug 24, 2023

@a-thaler: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-telemetry-manager-governance 6fecec0 link false /test pull-telemetry-manager-governance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot merged commit 4dd9621 into kyma-project:main Aug 24, 2023
@a-thaler a-thaler deleted the traces branch August 24, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation changes kind/feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants