Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make insecure flag in tls config optional #360

Merged
merged 1 commit into from
Aug 24, 2023
Merged

fix: Make insecure flag in tls config optional #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apis/telemetry/v1alpha1/shared_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ type Header struct {

type OtlpTLS struct {
// Defines whether to send requests using plaintext instead of TLS.
Insecure bool `json:"insecure"`
Insecure bool `json:"insecure,omitempty"`
// Defines whether to skip server certificate verification when using TLS.
InsecureSkipVerify bool `json:"insecureSkipVerify,omitempty"`
// Defines an optional CA certificate for server certificate verification when using TLS. The certificate needs to be provided in PEM format.
Expand Down
2 changes: 0 additions & 2 deletions config/crd/bases/telemetry.kyma-project.io_tracepipelines.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,6 @@ spec:
type: object
type: object
type: object
required:
- insecure
type: object
required:
- endpoint
Expand Down
2 changes: 0 additions & 2 deletions config/development/telemetry.kyma-project.io_metricpipelines.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,6 @@ spec:
type: object
type: object
type: object
required:
- insecure
type: object
required:
- endpoint
Expand Down
2 changes: 1 addition & 1 deletion docs/user/resources/04-tracepipeline.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ For details, see the [TracePipeline specification file](https://github.com/kyma-
| **output.​otlp.​tls.​cert.​valueFrom.​secretKeyRef.​key** | string | |
| **output.​otlp.​tls.​cert.​valueFrom.​secretKeyRef.​name** | string | |
| **output.​otlp.​tls.​cert.​valueFrom.​secretKeyRef.​namespace** | string | |
| **output.​otlp.​tls.​insecure** (required) | boolean | Defines whether to send requests using plaintext instead of TLS. |
| **output.​otlp.​tls.​insecure** | boolean | Defines whether to send requests using plaintext instead of TLS. |
| **output.​otlp.​tls.​insecureSkipVerify** | boolean | Defines whether to skip server certificate verification when using TLS. |
| **output.​otlp.​tls.​key** | object | Defines the client key to use when using TLS. The key needs to be provided in PEM format. |
| **output.​otlp.​tls.​key.​value** | string | Value that can contain references to Secret values. |
Expand Down
2 changes: 1 addition & 1 deletion docs/user/resources/05-metricpipeline.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ For details, see the [MetricPipeline specification file](https://github.com/kyma
| **output.​otlp.​tls.​cert.​valueFrom.​secretKeyRef.​key** | string | |
| **output.​otlp.​tls.​cert.​valueFrom.​secretKeyRef.​name** | string | |
| **output.​otlp.​tls.​cert.​valueFrom.​secretKeyRef.​namespace** | string | |
| **output.​otlp.​tls.​insecure** (required) | boolean | Defines whether to send requests using plaintext instead of TLS. |
| **output.​otlp.​tls.​insecure** | boolean | Defines whether to send requests using plaintext instead of TLS. |
| **output.​otlp.​tls.​insecureSkipVerify** | boolean | Defines whether to skip server certificate verification when using TLS. |
| **output.​otlp.​tls.​key** | object | Defines the client key to use when using TLS. The key needs to be provided in PEM format. |
| **output.​otlp.​tls.​key.​value** | string | Value that can contain references to Secret values. |
Expand Down