PR-506 - merge #102
Open
PR-506 - merge #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
1. add on-demand workflow run for testing purposes. 2. remove `staging` dependency for basic tests
Use what's in the Makefile.
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3.2.0 to 4.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/docker/build-push-action/releases">docker/build-push-action's releases</a>.</em></p> <blockquote> <h2>v4.0.0</h2> <blockquote> <p><strong>Note</strong></p> <p>Buildx v0.10 enables support for a minimal <a href="https://slsa.dev/provenance/">SLSA Provenance</a> attestation, which requires support for <a href="https://github.com/opencontainers/image-spec">OCI-compliant</a> multi-platform images. This may introduce issues with registry and runtime support (e.g. <a href="https://github-redirect.dependabot.com/docker/buildx/issues/1533">Google Cloud Run and AWS Lambda</a>). You can optionally disable the default provenance attestation functionality using <code>provenance: false</code>.</p> </blockquote> <ul> <li>Revert disable provenance by default if not set by <a href="https://github.com/crazy-max"><code>@crazy-max</code></a> in <a href="https://github-redirect.dependabot.com/docker/build-push-action/pull/784">docker/build-push-action#784</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v3.3.1...v4.0.0">https://github.com/docker/build-push-action/compare/v3.3.1...v4.0.0</a></p> <h2>v3.3.1</h2> <ul> <li>Disable provenance by default if not set by <a href="https://github.com/crazy-max"><code>@crazy-max</code></a> (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/781">#781</a>)</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v3.3.0...v3.3.1">https://github.com/docker/build-push-action/compare/v3.3.0...v3.3.1</a></p> <h2>v3.3.0</h2> <blockquote> <p><strong>Note</strong></p> <p>Buildx v0.10 enables support for a minimal <a href="https://slsa.dev/provenance/">SLSA Provenance</a> attestation, which requires support for <a href="https://github.com/opencontainers/image-spec">OCI-compliant</a> multi-platform images. This may introduce issues with registry and runtime support (e.g. <a href="https://github-redirect.dependabot.com/docker/buildx/issues/1533">Google Cloud Run and AWS Lambda</a>). You can optionally disable the default provenance attestation functionality using <code>provenance: false</code>.</p> </blockquote> <ul> <li>Add <code>attests</code>, <code>provenance</code> and <code>sbom</code> inputs by <a href="https://github.com/crazy-max"><code>@crazy-max</code></a> (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/746">#746</a> <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/759">#759</a>)</li> <li>Log GitHub Actions runtime token access controls by <a href="https://github.com/crazy-max"><code>@crazy-max</code></a> (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/707">#707</a>)</li> <li>Examples moved to <a href="https://docs.docker.com/build/ci/github-actions/examples/">docs website</a> by <a href="https://github.com/crazy-max"><code>@crazy-max</code></a> (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/718">#718</a>)</li> <li>Bump minimatch from 3.0.4 to 3.1.2 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/732">#732</a>)</li> <li>Bump csv-parse from 5.3.0 to 5.3.3 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/729">#729</a>)</li> <li>Bump json5 from 2.2.0 to 2.2.3 (<a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/749">#749</a>)</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push-action/compare/v3.2.0...v3.3.0">https://github.com/docker/build-push-action/compare/v3.2.0...v3.3.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/docker/build-push-action/commit/3b5e8027fcad23fda98b2e3ac259d8d67585f671"><code>3b5e802</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/784">#784</a> from crazy-max/enable-provenance</li> <li><a href="https://github.com/docker/build-push-action/commit/02d3266a89e5dfed960723e6127886a5adc7eb2f"><code>02d3266</code></a> update generated content</li> <li><a href="https://github.com/docker/build-push-action/commit/f403dafe18abeb00b9d5976ab285a9f457520f29"><code>f403daf</code></a> revert disable provenance by default if not set</li> <li><a href="https://github.com/docker/build-push-action/commit/1104d471370f9806843c095c1db02b5a90c5f8b6"><code>1104d47</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/781">#781</a> from crazy-max/disable-provenance</li> <li><a href="https://github.com/docker/build-push-action/commit/838bf90c88a4d6a02272e7afa2e4e2227b96f2dc"><code>838bf90</code></a> update generated content</li> <li><a href="https://github.com/docker/build-push-action/commit/337a09d182ee8c86aa958168dc985219e49e4b3b"><code>337a09d</code></a> disable provenance by default if not set</li> <li><a href="https://github.com/docker/build-push-action/commit/37abcedcc1da61a57767b7588cb9d03eb57e28b3"><code>37abced</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/760">#760</a> from crazy-max/test-envs</li> <li><a href="https://github.com/docker/build-push-action/commit/67109bc4b2230dc1ac72d54058d11285dc26bd87"><code>67109bc</code></a> test: move envs to jest config</li> <li><a href="https://github.com/docker/build-push-action/commit/d1b0eb0a29d50896608d0b3a0fd3c012fef617d8"><code>d1b0eb0</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/docker/build-push-action/issues/759">#759</a> from crazy-max/fix-provenance-input</li> <li><a href="https://github.com/docker/build-push-action/commit/a0635fe7cdb196c0c076b004dfdc1cab820ef1d4"><code>a0635fe</code></a> update generated content</li> <li>Additional commits viewable in <a href="https://github.com/docker/build-push-action/compare/v3.2.0...v4.0.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Purely a build pipeline PR. No changes in the app code. Here are the changes: 1. Periodically checks `main` branch for changes 2. Creates PR on `releases` base (target) branch 3. Deploys built image on staging (droplet setup WIP) Changes to the repository: 1. Create a `releases` branch 2. Create `staging` environment 3. Give `staging` access to `'releases` branch 4. `releases` branch should be able to push docker images to `ghcr.io` Github `ambuda` repo needs these `Setttings` changes to get to a working staging setup.
## Tests 1. built container with make docker-start 2. checked Texts, Dictionaries, and Proofing pages. 3. tested `proofing > project > edit > search` page 4. tested `proofing > project > edit > search and replace` page ## To do 1. Test actual `search and replace`. I could not find a pre-existing text in db to test this feature. 2. add support in translation files
1. username validator checks for spaces and upper bound on length is 64. 2. a password validator puts 256 as an upper bound on length. Otherwise, to avert any memory overruns by a malicious user or due to an unintentional error. 3. email address validator puts 254 as an upper bound on length. 4. username and email addresses are now case insensitive ## Tests ### Postitive testcases 1. signin works 2. register works ### Negative testcases 1. check sign-in with a username containing spaces fails 2. check sign-in with 124 characters username 3. check sign-in with 4 and 257 character length passwords
Search and replace a string works. May need stylesheet changes to pretty it up. Completes ambuda-org#455. Closed ambuda-org#407. Created a new clean branch and as the base branch for ambuda-org#470 pulled an existing commit. ## Tests See screenshots on PR ambuda-org#476.
Without this, the admin interface is broken. Along the way, I slightly cleaned up the model edit form.
Ruff is a new all-in-one Python linter that combines several previous tools and implements them more quickly. This PR switches to Ruff and cleans up various parts of the code that Ruff has flagged.
- show usernames instead of user IDs and text slugs instead of text IDs - block deleting users through the admin interface - make some small CSS/template changes - decrease test coverage threshold to 77% temporarily
This commit adds various tests so that our code stays above our 80% coverage bar. Other changes: - Add partial tests for seed scripts and `checks.py` - Standardize user credentials for users in unit tests
- Show sidebars on tool pages (search, replace, OCR) - Change `replace` permissions to p2, since it can be easily abused - Show admin tab on project pages - Show admin tab on user pages - Add more unit tests
This is mainly a CSS/HTML change. A follow-up PR will extend these changes to the "preview" page.
Upgrade the Babel package to version ^2.12 in response to the Python version upgrade. Fixes ambuda-org#483.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main/PR-506 merge is open