Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[proofing] Add partial work for search+replace #455

Merged
merged 1 commit into from
Feb 22, 2023
Merged

[proofing] Add partial work for search+replace #455

merged 1 commit into from
Feb 22, 2023

Conversation

kvchitrapu
Copy link
Collaborator

@kvchitrapu kvchitrapu commented Feb 20, 2023 •
edited
Loading

Tests

  1. built container with make docker-start
  2. checked Texts, Dictionaries, and Proofing pages.
  3. tested proofing > project > edit > search page
  4. tested proofing > project > edit > search and replace page

To do

  1. Test actual search and replace. I could not find a pre-existing text in db to test this feature.
  2. add support in translation files

@kvchitrapu
Copy link
Collaborator Author

Closed #452 and raised this PR to address #452 (comment). Now no old commits are visible in this PR commits tab.

@kvchitrapu kvchitrapu requested a review from akprasad February 20, 2023 20:31
@kvchitrapu
Copy link
Collaborator Author

@akprasad , PR is ready for review.

@kvchitrapu kvchitrapu mentioned this pull request Feb 20, 2023
Closed
@akprasad akprasad changed the title project-wide search and replace (wip) Add partial work for search+replace Feb 22, 2023
@akprasad akprasad changed the title Add partial work for search+replace [proofing] Add partial work for search+replace Feb 22, 2023
akprasad
akprasad approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@akprasad akprasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I can take it from here.

@akprasad akprasad merged commit 10cf5fd into ambuda-org:main Feb 22, 2023
This was referenced Mar 1, 2023
Closed
Closed
@kvchitrapu kvchitrapu mentioned this pull request Mar 18, 2023
Merged
akprasad pushed a commit that referenced this pull request Mar 24, 2023
@kvchitrapu
[proofing] add search and replace
515b046 
Search and replace a string works. May need stylesheet changes to pretty
it up. Completes #455.

Closed #407. Created a new clean branch and as the base branch for #470
pulled an existing commit.

## Tests

See screenshots on PR #476.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akprasad akprasad akprasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvchitrapu @akprasad