-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[proofing] search+replace function #470
Conversation
Thanks for this. Here's the flow I have in mind:
IIUC this PR completes the implementation of (2). Do you feel comfortable trying (3) as well? |
You're right. I completed #2. From our previous exchange on this issue, I understood that the user manually cherrypicks the changes and updates the edit page. What you listed as #3 is key to a better proofer experience. I'll give it a shot. |
Thanks -- please feel free to give #3 a shot as part of this PR. |
I made the required changes. Now testing and debugging them. I am hoping to send a PR update this weekend. |
@akprasad, I found a code bug on Saturday but haven't had a chance to work on it yet. I'll resolve the issue as soon as possible. |
@akprasad , I have the end-to-end flow working. Please review. Unittest coverage is not at 80%. I'll check tomorrow. Potential Improvements
|
Feature
Search and replace a string works. May need stylesheet changes to pretty it up. Completes #455.
Tests