Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eviction thresholds parameters #42702

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Add eviction thresholds parameters #42702

merged 1 commit into from
Oct 15, 2023

Conversation

Affan-7
Copy link
Contributor

@Affan-7 Affan-7 commented Aug 24, 2023 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Aug 24, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Aug 24, 2023
@Affan-7
Copy link
Contributor Author

Affan-7 commented Aug 24, 2023

/cc @sftim @vaibhav2107

@Affan-7 Affan-7 mentioned this pull request Aug 24, 2023
Closed
sftim
sftim reviewed Aug 24, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

content/en/docs/tasks/administer-cluster/kubelet-config-file.md Outdated Show resolved Hide resolved
@Affan-7 Affan-7 force-pushed the kubelet-parameters-via-config branch from 0850652 to ed95c29 Compare August 24, 2023 10:45
@netlify
Copy link

netlify bot commented Aug 24, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0850652
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64e730266e0dc10008cab7ec
😎 Deploy Preview https://deploy-preview-42702--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Affan-7 Affan-7 requested a review from sftim August 24, 2023 10:48
@netlify
Copy link

netlify bot commented Aug 24, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 27473c3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6513f136f692a5000823b9cd
😎 Deploy Preview https://deploy-preview-42702--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

vaibhav2107
vaibhav2107 reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@vaibhav2107 vaibhav2107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4a016fddf2ccc175cd89ca6a1526a5d531063ca1

sftim
sftim reviewed Aug 25, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please see inline feedback, and also:

  • write “kubelet” in lower case

content/en/docs/tasks/administer-cluster/kubelet-config-file.md Outdated Show resolved Hide resolved
@Affan-7 Affan-7 force-pushed the kubelet-parameters-via-config branch from ed95c29 to 96c3d11 Compare August 25, 2023 16:48
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2023
@Affan-7 Affan-7 requested a review from sftim August 26, 2023 03:42
@Affan-7
Copy link
Contributor Author

Affan-7 commented Aug 26, 2023

Hi @sftim, this CI failure looks interesting. Should we increase the maximum allowed runtime for deploy preview?

A similar error in: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64e8b65bfc1e730008026aad

@Affan-7 Affan-7 force-pushed the kubelet-parameters-via-config branch from 96c3d11 to 9dc1f0e Compare September 2, 2023 10:12
@Affan-7
Copy link
Contributor Author

Affan-7 commented Sep 6, 2023

/joke

@k8s-ci-robot
Copy link
Contributor

@Affan-7: Why did the kid cross the playground? To get to the other slide.

In response to this:

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sftim
Copy link
Contributor

sftim commented Sep 6, 2023

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Sep 6, 2023
@sftim
Copy link
Contributor

sftim commented Sep 6, 2023

/sig node
LGTM for docs. I recommend a technical review; @kubernetes/sig-node-pr-reviews does this look right?

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. labels Sep 6, 2023
@pacoxu
Copy link
Member

pacoxu commented Sep 6, 2023

https://kubernetes.io/docs/concepts/scheduling-eviction/node-pressure-eviction/#minimum-eviction-reclaim has another example.

@Affan-7 Affan-7 force-pushed the kubelet-parameters-via-config branch 2 times, most recently from 03f5d43 to b38d03e Compare September 8, 2023 07:34
pacoxu
pacoxu reviewed Sep 8, 2023
View reviewed changes
Copy link
Member

@pacoxu pacoxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content LGTM except for some nits. Leave to sig-doc reviewers.

content/en/docs/tasks/administer-cluster/kubelet-config-file.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/kubelet-config-file.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/kubelet-config-file.md Outdated Show resolved Hide resolved
@Affan-7 Affan-7 force-pushed the kubelet-parameters-via-config branch from b38d03e to fb63160 Compare September 8, 2023 07:43
@Affan-7 Affan-7 force-pushed the kubelet-parameters-via-config branch from 52f8016 to 590735a Compare September 21, 2023 09:49
@Affan-7 Affan-7 requested a review from tengqm September 25, 2023 06:21
@Affan-7 Affan-7 force-pushed the kubelet-parameters-via-config branch from 590735a to fe0fa31 Compare September 25, 2023 06:42
@tengqm
Copy link
Contributor

tengqm commented Sep 25, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 80ebba8475c7c96b226c60e2a13c5ad484c3ae06

@tengqm
Copy link
Contributor

tengqm commented Sep 26, 2023

@Affan-7 Please squash your PR into a single commit and git push -f again to trigger the gate.

@Affan-7 @tengqm
Add eviction thresholds parameters
27473c3 
Update content/en/docs/tasks/administer-cluster/kubelet-config-file.md

Co-authored-by: Qiming Teng <[email protected]>
@Affan-7 Affan-7 force-pushed the kubelet-parameters-via-config branch from fe0fa31 to 27473c3 Compare September 27, 2023 09:09
@Affan-7
Copy link
Contributor Author

Affan-7 commented Sep 27, 2023

@Affan-7 Please squash your PR into a single commit and git push -f again to trigger the gate.

Done!

@sftim
Copy link
Contributor

sftim commented Oct 15, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit f8161f8 into kubernetes:main Oct 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu left review comments

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@mtaufen mtaufen Awaiting requested review from mtaufen

@vaibhav2107 vaibhav2107 Awaiting requested review from vaibhav2107

@sftim sftim Awaiting requested review from sftim

@tengqm tengqm Awaiting requested review from tengqm

Assignees

@tengqm tengqm

@vaibhav2107 vaibhav2107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
SIG Scheduling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance and add more evictionHard thresholds in example yaml to encourage holistic parameter changes
6 participants
@Affan-7 @k8s-ci-robot @sftim @pacoxu @tengqm @vaibhav2107