Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance and add more evictionHard thresholds in example yaml to encourage holistic parameter changes #42105

Closed
vaibhav2107 opened this issue Jul 20, 2023 · 5 comments · Fixed by #42702
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@vaibhav2107
Copy link
Member

This is a Bug Report

Problem:
As we know that, in eviction hard thresholds, when we change the default value of any one of the four parameters (memory.available, nodefs.available, imagefs.available, nodefs.inodesFree), then the value of other parameters will be set to 0.
Although this is an expected behaviour but I think it's not a good motivation for user to change only the one parameter as given in this example. As setting other parameters to 0 is not a good scenario.
Proposed Solution:
Is there any good case by setting the other parameters to 0 or we should change the example to motivate users to change all parameters
Page to Update:
https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/

@vaibhav2107 vaibhav2107 added the kind/bug Categorizes issue or PR as related to a bug. label Jul 20, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 20, 2023
@vaibhav2107
Copy link
Member Author

/language en

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 20, 2023
@dipesh-rawat
Copy link
Member

/retitle Enhance and add more evictionHard thresholds in example yaml to encourage holistic parameter changes

@k8s-ci-robot k8s-ci-robot changed the title Issue in https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/#create-the-config-file Enhance and add more evictionHard thresholds in example yaml to encourage holistic parameter changes Jul 20, 2023
@sftim
Copy link
Contributor

sftim commented Jul 20, 2023

/remove-kind bug
/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jul 20, 2023
@Affan-7
Copy link
Contributor

Affan-7 commented Jul 22, 2023

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
5 participants