Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eviction thresholds parameters #42142

Closed
wants to merge 0 commits into from
Closed

Add eviction thresholds parameters #42142

wants to merge 0 commits into from

Conversation

Affan-7
Copy link
Contributor

@Affan-7 Affan-7 commented Jul 23, 2023

This closes #42105

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jul 23, 2023
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 23, 2023
@netlify
Copy link

netlify bot commented Jul 23, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit cb342d9
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64e72e7abb45eb0007c4ddb9
😎 Deploy Preview https://deploy-preview-42142--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Affan-7 Affan-7 requested review from windsonsea and sftim July 31, 2023 16:25
@Affan-7
Copy link
Contributor Author

Affan-7 commented Aug 3, 2023

/auto-cc

@k8s-ci-robot k8s-ci-robot requested a review from kbhawkey August 3, 2023 07:43
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2023
@vaibhav2107
Copy link
Member

HI @Affan-7, could you please rebase the PR to be merged

@sftim
Copy link
Contributor

sftim commented Aug 24, 2023

If you can @Affan-7, please squash this to 1 commit. There are videos on YouTube (etc) to help you learn more about what rebasing is and how to do it.

@Affan-7
Copy link
Contributor Author

Affan-7 commented Aug 24, 2023

Don't sweat it, @sftim, I'm a pro at squashing commits! 😉

@Affan-7 Affan-7 force-pushed the kubelet-parameters-via-config branch from 7b53b1e to 38c226d Compare August 24, 2023 10:03
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2023
@Affan-7 Affan-7 force-pushed the kubelet-parameters-via-config branch from 60a4134 to 38c226d Compare August 24, 2023 10:18
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Affan-7 Affan-7 closed this Aug 24, 2023
@Affan-7 Affan-7 force-pushed the kubelet-parameters-via-config branch from 38c226d to cb342d9 Compare August 24, 2023 10:18
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Affan-7
Copy link
Contributor Author

Affan-7 commented Aug 24, 2023 •
edited
Loading

I faced a merge conflict 😅. Here is the new PR #42702.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradtopol bradtopol Awaiting requested review from bradtopol

@mtaufen mtaufen Awaiting requested review from mtaufen

@windsonsea windsonsea Awaiting requested review from windsonsea

@sftim sftim Awaiting requested review from sftim

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance and add more evictionHard thresholds in example yaml to encourage holistic parameter changes
5 participants
@Affan-7 @vaibhav2107 @sftim @k8s-ci-robot @windsonsea