Merge main into dev-1.25 branch: July 21st #35229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tim Bannister <[email protected]>
This PR proposes an update to the PR review guidelines. The proposed change is about the use of the "Request changes" or the "Approve" option when finishing a PR review. Neither of these two options should be encouraged. We may want to encourage reviewers to always use "Comment", because: - "Request changes" status is sticky and unnecessary. Placing a "/hold" should be okay because we do respect opinions from all reviewers/approvers. The "Request changes" status can only be discarded by people with privileges. We see quite a few cases where the reviewer left a "Request changes" mark and forgot to revisit a PR. Such a sticky status is not friendly to contributors or peer reviewers. - The "Approve" option is confusing. It is not considered by the prow as an approval IIUC. The PR has to be approved again even if it has been "approved" this way.
I added access to the statement explaining cluster role permissions in this document to make it clearer.
This PR fix the wrong guide according to the commit bellow: [apiserver: support egress selection name 'controlplane' and deprecate 'master'](kubernetes/kubernetes@a0aebf9)
…urces/validating-webhook-configuration-v1.md [zh-cn]Update content/zh-cn/docs/reference/kubernetes-api/extend-resources/validating-webhook-configuration-v1.md [zh-cn]Update content/zh-cn/docs/reference/kubernetes-api/extend-resources/validating-webhook-configuration-v1.md [zh-cn]Update content/zh-cn/docs/reference/kubernetes-api/extend-resources/validating-webhook-configuration-v1.md [zh-cn]Update content/zh-cn/docs/reference/kubernetes-api/extend-resources/validating-webhook-configuration-v1.md [zh-cn]Update content/zh-cn/docs/reference/kubernetes-api/extend-resources/validating-webhook-configuration-v1.md [zh-cn]Update content/zh-cn/docs/reference/kubernetes-api/extend-resources/validating-webhook-configuration-v1.md
There are deprecated kubelet flags related to garbage collection. These flags were listed in the `kubelet-garbage-collection.md` page, which was removed by b1573ad. Linking to the `kubelet` reference is not a good solution because users may still get confused what are the specific flags related to this behavior. This PR restores the table with the flags updated according to 1.24 version of `kubelet --help`.
All resource requests parse units the same way. Ephemeral storage previously had an upper case `K` as a valid unit but the kubernetes server can not parse this value. Similar to memory, add a statement regarding that a lowercase `m` will be accepted by the kubernetes server, but is probably an incorrect request.
…urces/pod-disruption-budget-v1.md [zh-cn]Update content/zh-cn/docs/reference/kubernetes-api/policy-resources/pod-disruption-budget-v1.md [zh-cn]Update content/zh-cn/docs/reference/kubernetes-api/policy-resources/pod-disruption-budget-v1.md [zh-cn]Update content/zh-cn/docs/reference/kubernetes-api/policy-resources/pod-disruption-budget-v1.md [zh-cn]Update content/zh-cn/docs/reference/kubernetes-api/policy-resources/pod-disruption-budget-v1.md
[zh-cn] Translate PDB-v1
…with-affinity-anti-affinity.yaml [zh-cn]Update pod-with-affinity-anti-affinity.yaml
fix typo in job example
[zh-cn]Fixed a word in explore-intro.html
Signed-off-by: utkarsh-singh1 <[email protected]>
…webhook-configuration-v1 [zh-cn] Translate ValidatingWebhookConfiguration-v1
[zh-cn] resync /partners/_index.html
…-signed-images Updated the expired link for Configuration option
…te_KubeletCredentialProvider Fix KubeletCredentialProvider feature state
Fix wrong guide for egress selection.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
language/id
|
/retitle Merge main into dev-1.25 branch: July 21st And I think the PR description is not clear. Seems like merge
Maybe this would be better
|
k8s-ci-robot
changed the title
Sounds good. I just copied over the description from a previous branch sync PR |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
HI just curious if we plan to merge main to dev-1.25, why don't we do dev-1.25...main ? Just to avoid confusion on if any personal commit added :) |
|
/lgtm
|
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 78585554665b8c47d47e36e82fa797799745d678
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR syncs the main branch with the dev-1.25 branch.