Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the expired link for Configuration option #34980

Merged

Conversation

utkarsh-singh1
Copy link
Contributor

Description:
The Configuration option still had a broken link.

Proposed Solution:
Added this link as a replacement - https://github.com/sigstore/cosign/blob/main/USAGE.md#detailed-usage

Page to Update:
https://kubernetes.io/docs/tasks/administer-cluster/verify-signed-images/#verifying-image-signatures-with-admission-controller

fixes: #34854

Signed-off-by: utkarsh-singh1 <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 13, 2022
@k8s-ci-robot k8s-ci-robot requested review from bradtopol and tengqm July 13, 2022 09:56
@netlify
Copy link

netlify bot commented Jul 13, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 043c9f0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62ce968df2710b0009a15b18
😎 Deploy Preview https://deploy-preview-34980--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Sea-n
Copy link
Member

Sea-n commented Jul 13, 2022

Confirmed.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1601f770ee99449485111e3ed25c34d33c1b26c2

@kbhawkey
Copy link
Contributor

Thanks @utkarsh-singh1

/kind cleanup
/approve

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 276a6d7 into kubernetes:main Jul 13, 2022
@utkarsh-singh1
Copy link
Contributor Author

Hi @Sea-n @kbhawkey, thanks for reviewing and approving this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify Signed Container Images - Broken links
4 participants