Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in job example #34266

Merged
merged 1 commit into from
Jul 13, 2022
Merged

fix typo in job example #34266

merged 1 commit into from
Jul 13, 2022

Conversation

alanssitis
Copy link
Contributor

@alanssitis alanssitis commented Jun 13, 2022

The perl command in the first job example was missing a pair of quotes. Added the missing quotes to the corresponding content/en yaml files.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 13, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: alanssitis / name: Alan Chung Ma (ba1f647)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 13, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @alanssitis!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jun 13, 2022
@k8s-ci-robot k8s-ci-robot added language/es Issues or PRs related to Spanish language language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/uk Issues or PRs related to Ukrainian language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 13, 2022
@netlify
Copy link

netlify bot commented Jun 13, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 79e4dee
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62ce3ffbe186e00009aef676
😎 Deploy Preview https://deploy-preview-34266--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Sea-n
Copy link
Member

Sea-n commented Jun 14, 2022

Hey @alanssitis,

Please limit this PR to fix only one language (i.e., only change content/en one).
Once the PR reviewed and merged, you can open PRs for each langs, or let other contributor do that.

Feel free to /unhold when it's done.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2022
@nitishfy
Copy link
Member

Hey @alanssitis , the changes look good but Please only change the file in en and not in another folders. Let other contributors do this job.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 14, 2022
@Sea-n
Copy link
Member

Sea-n commented Jun 14, 2022

Thanks! Now the PR is ready for review.

/unhold
/remove-language es id ja ko uk zh

@k8s-ci-robot k8s-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/es Issues or PRs related to Spanish language language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/uk Issues or PRs related to Ukrainian language language/zh Issues or PRs related to Chinese language labels Jun 14, 2022
@tengqm
Copy link
Contributor

tengqm commented Jun 15, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 58ce5d8542b3e2942f5e8b5db80252260fa47eaa

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2022
@reylejano
Copy link
Member

Hi @alanssitis , please rebase otherwise this PR will cause a merge conflict

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2022
@k8s-ci-robot k8s-ci-robot requested a review from tengqm July 13, 2022 03:46
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2022
@reylejano
Copy link
Member

Re-applying lgtm from comment
/lgtm

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4c057419cdf5db58b763b60bd3a30f6627926522

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit bc8e54d into kubernetes:main Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants