Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-cn] Part4:updated the term "群集" to "集群" #34964

Merged
merged 1 commit into from
Jul 18, 2022
Merged

[zh-cn] Part4:updated the term "群集" to "集群" #34964

merged 1 commit into from
Jul 18, 2022

Conversation

dapengJacky
Copy link
Contributor

@dapengJacky dapengJacky commented Jul 12, 2022 •
edited
Loading

Signed-off-by: jacky [email protected]

issue:#33735
fix issue part4 file typo

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 12, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dapengJacky / name: Jacky (4e7f8c9)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 12, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @dapengJacky!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 12, 2022
@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 12, 2022
@netlify
Copy link

netlify bot commented Jul 12, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit b7bfe02
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62d5243790f8430008f7d496
😎 Deploy Preview https://deploy-preview-34964--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Sea-n
Copy link
Member

Sea-n commented Jul 13, 2022

The files are not fully synced with upstream (English) version.

Feel free to /unhold once it's fully checked and synced.
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 13, 2022
@dapengJacky
Copy link
Contributor Author

dapengJacky commented Jul 14, 2022 •
edited
Loading

@Sea-n

The files are not fully synced with upstream (English) version.

I know what u mean,so what should I do now,can u give some advice?

@ydFu
Copy link
Member

ydFu commented Jul 14, 2022 •
edited
Loading

@Sea-n

The files are not fully synced with upstream (English) version.

I know what u mean,so what should I do now,can u give some advice?

@dapengJacky

Please refer to this link for command line instructions for synchronization in both Chinese and English.

https://kubernetes.io/zh-cn/docs/contribute/localization_zh/#%E6%9B%B4%E6%96%B0%E8%AF%91%E6%96%87

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 16, 2022
@dapengJacky
Copy link
Contributor Author

@Sea-n

The files are not fully synced with upstream (English) version.

I know what u mean,so what should I do now,can u give some advice?

@dapengJacky

Please refer to this link for command line instructions for synchronization in both Chinese and English.

https://kubernetes.io/zh-cn/docs/contribute/localization_zh/#%E6%9B%B4%E6%96%B0%E8%AF%91%E6%96%87

I have synced with upstream (English) version,please review again,thanks

@tengqm
Copy link
Contributor

tengqm commented Jul 17, 2022

please squash your PR into a single commit.

Sea-n
Sea-n reviewed Jul 17, 2022
View reviewed changes
Copy link
Member

@Sea-n Sea-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to revise some sentence to be more fluent.

content/zh-cn/case-studies/zalando/index.html Outdated Show resolved Hide resolved
content/zh-cn/case-studies/zalando/index.html Outdated Show resolved Hide resolved
content/zh-cn/case-studies/zalando/index.html Outdated Show resolved Hide resolved
content/zh-cn/case-studies/zalando/index.html Outdated Show resolved Hide resolved
content/zh-cn/case-studies/zalando/index.html Outdated Show resolved Hide resolved
content/zh-cn/case-studies/zalando/index.html Outdated Show resolved Hide resolved
@dapengJacky
Copy link
Contributor Author

It would be great to revise some sentence to be more fluent.

thanks,I have fixed this

@Sea-n
Copy link
Member

Sea-n commented Jul 18, 2022

Ah, forgot to unhold since the content is synced.
/unhold

And overall looks good to me, wait for others to provide more suggestions.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2022
@tengqm
Copy link
Contributor

tengqm commented Jul 18, 2022

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2022
@dapengJacky
Copy link
Contributor Author

/cc @ydFu
Could u help to review,thanks

ydFu
ydFu reviewed Jul 18, 2022
View reviewed changes
content/zh-cn/case-studies/ygrene/index.html Outdated Show resolved Hide resolved
content/zh-cn/case-studies/zalando/index.html Outdated Show resolved Hide resolved
content/zh-cn/case-studies/zalando/index.html Outdated Show resolved Hide resolved
content/zh-cn/case-studies/zalando/index.html Outdated Show resolved Hide resolved
content/zh-cn/case-studies/zalando/index.html Outdated Show resolved Hide resolved
@dapengJacky
[zh-cn] Part4:sync en version content and fix typo
b7bfe02 
Signed-off-by: jacky <[email protected]>

[zh-cn Part4]:synced with upstream (English) version

Signed-off-by: jacky <[email protected]>

[zh-cn] Part4: synced with upstream (English) version

Signed-off-by: jacky <[email protected]>

translate title and quote

Signed-off-by: jacky <[email protected]>

fix format

Signed-off-by: jacky <[email protected]>

[zh-cn] Part4:fix format

Signed-off-by: jacky <[email protected]>
@dapengJacky
Copy link
Contributor Author

@ydFu thanks,I have fixed

ydFu
ydFu approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,It looks like this is your first PR,keep it up.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm, ydFu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6cab24fde8142debde9d9b674e043620d0d4a1d5

@k8s-ci-robot k8s-ci-robot merged commit 4e6f2fe into kubernetes:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sea-n Sea-n Sea-n left review comments

@ydFu ydFu ydFu approved these changes

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@ydFu ydFu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dapengJacky @k8s-ci-robot @Sea-n @ydFu @tengqm