Reword commits that trigger warnings #17959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add caution to behavior of --from-env-file * Reword warning to fix grammar
`kubectl rolling-update` is the right command. Doc: https://kubernetes.io/docs/tasks/run-application/rolling-update-replication-controller/
* Adding vi document for create-cluster Signed-off-by: Dao Cong Tien <[email protected]> * Update cluster-intro.html * Update cluster-intro.html * Update cluster-intro.html
* Update files outdated Korean docs in dev-1.16-ko.5 (kubernetes#17537) * Update Korean glossary (kubernetes#17619) * Translate services-networking/endpoint-slices.md in Korean (kubernetes#17631) Co-Authored-By: Yuk, Yongsu <[email protected]> Co-Authored-By: June Yi <[email protected]> Co-Authored-By: Wook-Jin, Lee <[email protected]> Co-Authored-By: Seokho Son <[email protected]>
1. Fixed markdown error that endup as 404 error at the URL
https://kubernetes.io/ja/docs/reference/command-line-tools-reference/feature-gates/
See - CSI(Container Storage Interface) link.
2. Minikube links at
- content/ja/docs/tasks/tools/install-minikube.md
- content/ja/includes/task-tutorial-prereqs.md
3. Link to CRI page at
content/ja/docs/setup/production-environment/tools/kubeadm/install-kubeadm.md
4. Windows Nodes link at
https://kubernetes.io/ja/docs/setup/production-environment/windows/user-guide-windows-containers/
service-catalog is not part of kubernetes-incubator anymore
* Use feature-state template * Update certificate-rotation.md
* Document downloading the latest or a specific kops version Add links to Install Homebrew On MacOS, Linux * Update kops.md
Translate English sentences into Chinese
As https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale-walkthrough/ and kubernetes#16425 say, the hpa has already supported stateful set.
This change removes a duplicate link to the setup/best-practices/certificates page.
* Minor heading update according to the guideline Fixed title of the document to use title case as described in the community guidelines. * Capitalization fixes.
* Refernce link added for Flex and CSI volume Added reference link of Flex and CSI volume under `Components of the CCM` section. * Update content/en/docs/concepts/architecture/cloud-controller.md Co-Authored-By: Tim Bannister <[email protected]>
* incorrect command for sort-by kubectl get pods -n test --sort-by=.spec.capacity.storage, is incorrect for pod as pods will not have capacity.storage under .spec, rather it should be for PersistentVolume. So change the command kubectl get pv -n test --sort-by=.spec.capacity.storage * Update cheatsheet.md
A Service has targetPort to indicated Pod's containerPort (service.spec.ports.targetPort)
* Tweak kubectl plugins page - drop text about kubectl plugin beta status etc - fix output formatted as shell - address the reader as “you” - other tweaks * Update links & details for Krew * Update kubectl-plugins.md
* fix-up 404 urls * Revert "fix-up 404 urls" This reverts commit 4515c4d. * fix-ip 404 urls * fix-up 404 urls
* Update guaranteed-scheduling-critical-addon-pods.md cleanup old stuff again * Update content/en/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods.md Co-Authored-By: Tim Bannister <[email protected]> * Update guaranteed-scheduling-critical-addon-pods.md remove whitespace
Co-Authored-By: Giri Kuncoro <[email protected]> Co-Authored-By: Tim Bannister <[email protected]>
k8s-ci-robot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/blog
k8s-ci-robot
added
the
sig/docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the
do-not-mergewarning introduced into #17958.The warning was caused when the author of #17888 and #17889 manually removed the
do-not-merge/invalid-commit-messagelabels. Prow initially applied the labels when the author created multi-line commits that included GitHub keywords.