Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add statefulsets for ID localization. #16700

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Add statefulsets for ID localization. #16700

merged 1 commit into from
Dec 5, 2019

Conversation

irvifa
Copy link
Member

@irvifa irvifa commented Oct 5, 2019

Addresses #15341

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 5, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. language/id Issues or PRs related to Indonesian language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 5, 2019
@irvifa
Copy link
Member Author

irvifa commented Oct 5, 2019

/cc @kubernetes/sig-docs-id-reviews

@irvifa irvifa removed the request for review from Rajakavitha1 October 5, 2019 10:27
@irvifa
Copy link
Member Author

irvifa commented Oct 5, 2019

/assign

@netlify
Copy link

netlify bot commented Oct 5, 2019 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 9a49ad0

https://deploy-preview-16700--kubernetes-io-master-staging.netlify.com

@irvifa
Copy link
Member Author

irvifa commented Oct 5, 2019

Address jk8s/sig-docs-id#17

@irvifa
Copy link
Member Author

irvifa commented Oct 5, 2019

Related to jk8s/sig-docs-id#17

@irvifa irvifa requested review from phanama and qbl October 6, 2019 09:28
@girikuncoro girikuncoro mentioned this pull request Oct 7, 2019
Closed
45 tasks
@girikuncoro
Copy link
Contributor

I have reviewed this but it is currently blocked, because everytime I submit my PR review comments (77 comments and suggested changes), github is crying, any idea how to fix? most likely hit by this issue: envoyproxy/envoy#3125

girikuncoro
girikuncoro requested changes Oct 13, 2019
View reviewed changes
Copy link
Contributor

@girikuncoro girikuncoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on translating this important page! 🎉 I've given comments related to typos, styling, wordings, please address them before getting the PR in. I'm dividing my reviews into 2 parts to avoid Github crashing when reviewer gives too many reviews (or suggested changes?)

Also, please don't close the comment once you addressed (don't click the resolve comment), so that reviewer can easily verify and crosscheck, thanks!

content/id/docs/concepts/workloads/controllers/statefulset.md Outdated Show resolved Hide resolved
content/id/docs/concepts/workloads/controllers/statefulset.md

{{% capture overview %}}

StatefulSet merupakan salah satu objek API _workload_ yang digunakan untuk aplikasi _stateful_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think about translating workload to "beban kerja"?

cc @kubernetes/sig-docs-id-reviews

content/id/docs/concepts/workloads/controllers/statefulset.md Outdated Show resolved Hide resolved
content/id/docs/concepts/workloads/controllers/statefulset.md Outdated Show resolved Hide resolved
content/id/docs/concepts/workloads/controllers/statefulset.md Outdated Show resolved Hide resolved
content/id/docs/concepts/workloads/controllers/statefulset.md Outdated Show resolved Hide resolved
content/id/docs/concepts/workloads/controllers/statefulset.md Outdated Show resolved Hide resolved
content/id/docs/concepts/workloads/controllers/statefulset.md Outdated

#### Manajemen Pod secara Paralel

Manajemen Pod secara `Parallel` akan menyebabkan kontroler StatefulSet untuk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parallel in backtick style doesn't seem right, is it referring to specific "Parallel"? I believe this is taken from the English page

IMO the translated "paralel" makes more sense, wdyt?

content/id/docs/concepts/workloads/controllers/statefulset.md Outdated Show resolved Hide resolved
content/id/docs/concepts/workloads/controllers/statefulset.md Outdated Show resolved Hide resolved
@girikuncoro
Copy link
Contributor

@irvifa looking good, thanks for your continuous contribution to kubernetes docs and community! 🎉

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girikuncoro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 060cbcd into kubernetes:master Dec 5, 2019
zacharysarah pushed a commit to zacharysarah/website that referenced this pull request Dec 5, 2019
@irvifa
Add statefulsets for ID localization. (kubernetes#16700)
d83a005
zacharysarah pushed a commit to zacharysarah/website that referenced this pull request Dec 5, 2019
@irvifa
Add statefulsets for ID localization. (kubernetes#16700)
fe0fd2a
zacharysarah pushed a commit to zacharysarah/website that referenced this pull request Dec 5, 2019
@irvifa
Add statefulsets for ID localization. (kubernetes#16700)
5547a52
gochist added a commit to gochist/website that referenced this pull request Dec 5, 2019
@gochist
Reword commits that cause Prow warnings (#1)
ec5b784 
* Fix a command in kubectl cheatsheet (kubernetes#17888)

* Remove dead links to old getting started guides (kubernetes#17889)

* Change PowerShell example to use the -Raw flag (kubernetes#17645)

* Spelling correction (kubernetes#17895)

* fix some broken links (kubernetes#17897)

* update exmaple for job (kubernetes#17903)

* Deleted duplicate sentence and corrected typo (kubernetes#17902)

* Corrected the typo of 'chck' with 'check'

* Removed the duplicate sentence

* Fix a dead link (kubernetes#17900)

* fix 404 urls in kustomization.md (kubernetes#17793)

* Update kustomization.md

fix 404 urls in kustomization.md

* Update content/en/docs/tasks/manage-kubernetes-objects/kustomization.md

Co-Authored-By: Tim Bannister <[email protected]>

* update kustomization.md to be more stable

* Fix broken link to AWS provider settings source (kubernetes#17899)

* update style guide for styling component names (kubernetes#17588)

* update style guide for styling component names

- Attempt to outline style conventions for components
  and component tools
- Interested in comments and feedback

* update style examples

* style edits

- removed code style for components not cmd tools
- added style suggestion for namespaces
- cleaned up a few stray spaces

* fix output example in automated-tasks-with-cron-jobs.md (kubernetes#17906)

* Update an out-of-date link (kubernetes#17907)

Signed-off-by: umiblue <[email protected]>

* en-fr: Append Note To Alternative Linux Install (kubernetes#17827)

* Blog post: Gardener Project Update (kubernetes#17516)

* Add Gardener Project Update blog post

* Update and rename 2019-11-10-gardener-project-update.md to 2019-11-27-gardener-project-update.md

* Update and rename 2019-11-27-gardener-project-update.md to 2019-12-02-gardener-project-update.md

* Update KubeCon buttons for Shanghai (kubernetes#17916)

* fix path not consistent (kubernetes#17923)

* updated 3 logos on case studies page (kubernetes#17628)

* Update kube-scheduler.md (kubernetes#17283)

Fix grammar typo

* Add missing `systemctl` step for running `cri-o` (kubernetes#17926)

After installing `cri-o`, we must run `systemctl daemon-reload` before
trying to run `systemctl start crio`. Otherwise, `systemd` doesn't know
about the crio configuration.

Similar instructions already exist for installing docker - this diff
adds these instructions for crio.

* add cidr to glossary (kubernetes#17550)

* add CIDR

* modify cidr definition

* Update content/en/docs/reference/glossary/cidr.md

Co-Authored-By: Chris <[email protected]>

* Update content/en/docs/reference/glossary/cidr.md

Co-Authored-By: Chris <[email protected]>

* specify components requiring feature gate (kubernetes#17922)

* specify components requiring feature gate 

currently, TTLafterfinished feature gate is a flag that can be passed to kube-apiserver, kube-scheduler and kube-controller-manager. The current description doesn't state what components to pass the flag to.

* specify components requiring feature gate

* Fixed hot reload panic of local hugo issue. (kubernetes#17894)

* fix-up 404 urls (kubernetes#17936)

* fix-up 404 urls

* Revert "fix-up 404 urls"

This reverts commit 4515c4d.

* fix-ip 404 urls

* fix-up 404 urls

* Update guaranteed-scheduling-critical-addon-pods.md (kubernetes#17151)

* Update guaranteed-scheduling-critical-addon-pods.md

cleanup old stuff again

* Update content/en/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods.md

Co-Authored-By: Tim Bannister <[email protected]>

* Update guaranteed-scheduling-critical-addon-pods.md

remove whitespace

* correct diagram label (kubernetes#17942)

* fix-up 404 urls (kubernetes#17941)

* fix-up 404 urls

* Revert "fix-up 404 urls"

This reverts commit 4515c4d.

* fix-ip 404 urls

* fix-up 404 urls

* fix-up 404 urls

Revert "fix-up 404 urls"

This reverts commit 4515c4d.

fix-ip 404 urls

fix-up 404 urls

* fix-up 404 urls

* Translate Minikube environment to French (kubernetes#17939)

* Freshen the list of English content approvers for SIG Docs (kubernetes#17929)

* Add YouTube social button in header and footer (kubernetes#16838)

* Update the cluster create and disable commands (kubernetes#17947)

* Initialize DNS Pod Service for ID Localization. (kubernetes#16707)

Co-Authored-By: Giri Kuncoro <[email protected]>
Co-Authored-By: Tim Bannister <[email protected]>

* Add statefulsets for ID localization. (kubernetes#16700)

* Initialize Common Label for ID Localization. (kubernetes#16706)

* Add job running into completion in ID Localization. (kubernetes#16705)

* Updated kubeone URL (kubernetes#17766)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girikuncoro girikuncoro girikuncoro requested changes

@phanama phanama Awaiting requested review from phanama

@qbl qbl Awaiting requested review from qbl

Assignees

@girikuncoro girikuncoro

@irvifa irvifa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irvifa @girikuncoro @k8s-ci-robot