Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kube-scheduler.md #17283

Conversation

xtreme-sameer-vohra
Copy link
Contributor

Fix grammar typo

Fix grammar typo
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 29, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @xtreme-sameer-vohra!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 29, 2019
@netlify
Copy link

netlify bot commented Oct 29, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 8caa2f8

https://deploy-preview-17283--kubernetes-io-master-staging.netlify.com

@bradtopol
Copy link
Contributor

/assign

@bradtopol
Copy link
Contributor

@xtreme-sameer-vohra Thank you for your contribution. Please sign the CLA so we can accept your PR for review

@tfogo
Copy link
Contributor

tfogo commented Nov 13, 2019

Hi @xtreme-sameer-vohra, thanks for the PR! Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA so that we can review this PR, thanks!

@xtreme-sameer-vohra
Copy link
Contributor Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 27, 2019
@xtreme-sameer-vohra
Copy link
Contributor Author

Hey @tfogo , sorry it took so long, but its done now

@Rajakavitha1
Copy link
Contributor

Thanks for the PR @xtreme-sameer-vohra !
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rajakavitha1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit 29ca5ea into kubernetes:master Dec 3, 2019
@xtreme-sameer-vohra xtreme-sameer-vohra deleted the xtreme-sameer-vohra-patch-1 branch December 3, 2019 16:03
zacharysarah pushed a commit to zacharysarah/website that referenced this pull request Dec 5, 2019
zacharysarah pushed a commit to zacharysarah/website that referenced this pull request Dec 5, 2019
zacharysarah pushed a commit to zacharysarah/website that referenced this pull request Dec 5, 2019
gochist added a commit to gochist/website that referenced this pull request Dec 5, 2019
* Fix a command in kubectl cheatsheet (kubernetes#17888)

* Remove dead links to old getting started guides (kubernetes#17889)

* Change PowerShell example to use the -Raw flag (kubernetes#17645)

* Spelling correction (kubernetes#17895)

* fix some broken links (kubernetes#17897)

* update exmaple for job (kubernetes#17903)

* Deleted duplicate sentence and corrected typo (kubernetes#17902)

* Corrected the typo of 'chck' with 'check'

* Removed the duplicate sentence

* Fix a dead link (kubernetes#17900)

* fix 404 urls in kustomization.md (kubernetes#17793)

* Update kustomization.md

fix 404 urls in kustomization.md

* Update content/en/docs/tasks/manage-kubernetes-objects/kustomization.md

Co-Authored-By: Tim Bannister <[email protected]>

* update kustomization.md to be more stable

* Fix broken link to AWS provider settings source (kubernetes#17899)

* update style guide for styling component names (kubernetes#17588)

* update style guide for styling component names

- Attempt to outline style conventions for components
  and component tools
- Interested in comments and feedback

* update style examples

* style edits

- removed code style for components not cmd tools
- added style suggestion for namespaces
- cleaned up a few stray spaces

* fix output example in automated-tasks-with-cron-jobs.md (kubernetes#17906)

* Update an out-of-date link (kubernetes#17907)

Signed-off-by: umiblue <[email protected]>

* en-fr: Append Note To Alternative Linux Install (kubernetes#17827)

* Blog post: Gardener Project Update (kubernetes#17516)

* Add Gardener Project Update blog post

* Update and rename 2019-11-10-gardener-project-update.md to 2019-11-27-gardener-project-update.md

* Update and rename 2019-11-27-gardener-project-update.md to 2019-12-02-gardener-project-update.md

* Update KubeCon buttons for Shanghai (kubernetes#17916)

* fix path not consistent (kubernetes#17923)

* updated 3 logos on case studies page (kubernetes#17628)

* Update kube-scheduler.md (kubernetes#17283)

Fix grammar typo

* Add missing `systemctl` step for running `cri-o` (kubernetes#17926)

After installing `cri-o`, we must run `systemctl daemon-reload` before
trying to run `systemctl start crio`. Otherwise, `systemd` doesn't know
about the crio configuration.

Similar instructions already exist for installing docker - this diff
adds these instructions for crio.

* add cidr to glossary (kubernetes#17550)

* add CIDR

* modify cidr definition

* Update content/en/docs/reference/glossary/cidr.md

Co-Authored-By: Chris <[email protected]>

* Update content/en/docs/reference/glossary/cidr.md

Co-Authored-By: Chris <[email protected]>

* specify components requiring feature gate (kubernetes#17922)

* specify components requiring feature gate 

currently, TTLafterfinished feature gate is a flag that can be passed to kube-apiserver, kube-scheduler and kube-controller-manager. The current description doesn't state what components to pass the flag to.

* specify components requiring feature gate

* Fixed hot reload panic of local hugo issue. (kubernetes#17894)

* fix-up 404 urls (kubernetes#17936)

* fix-up 404 urls

* Revert "fix-up 404 urls"

This reverts commit 4515c4d.

* fix-ip 404 urls

* fix-up 404 urls

* Update guaranteed-scheduling-critical-addon-pods.md (kubernetes#17151)

* Update guaranteed-scheduling-critical-addon-pods.md

cleanup old stuff again

* Update content/en/docs/tasks/administer-cluster/guaranteed-scheduling-critical-addon-pods.md

Co-Authored-By: Tim Bannister <[email protected]>

* Update guaranteed-scheduling-critical-addon-pods.md

remove whitespace

* correct diagram label (kubernetes#17942)

* fix-up 404 urls (kubernetes#17941)

* fix-up 404 urls

* Revert "fix-up 404 urls"

This reverts commit 4515c4d.

* fix-ip 404 urls

* fix-up 404 urls

* fix-up 404 urls

Revert "fix-up 404 urls"

This reverts commit 4515c4d.

fix-ip 404 urls

fix-up 404 urls

* fix-up 404 urls

* Translate Minikube environment to French (kubernetes#17939)

* Freshen the list of English content approvers for SIG Docs (kubernetes#17929)

* Add YouTube social button in header and footer (kubernetes#16838)

* Update the cluster create and disable commands (kubernetes#17947)

* Initialize DNS Pod Service for ID Localization. (kubernetes#16707)

Co-Authored-By: Giri Kuncoro <[email protected]>
Co-Authored-By: Tim Bannister <[email protected]>

* Add statefulsets for ID localization. (kubernetes#16700)

* Initialize Common Label for ID Localization. (kubernetes#16706)

* Add job running into completion in ID Localization. (kubernetes#16705)

* Updated kubeone URL (kubernetes#17766)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants